# HG changeset patch # User Marcin Kuzminski # Date 1359069181 -3600 # Node ID 9e76876a0690e8a35feb1356de795108d3be6deb # Parent 42d7ca49d073141dd94108b9d7910d5d939945a2 Global permission update with "overwrite existing settings" shouldn't override private repositories. It's to confusing to users, and private repos should be always private diff -r 42d7ca49d073 -r 9e76876a0690 rhodecode/model/permission.py --- a/rhodecode/model/permission.py Thu Jan 24 22:41:53 2013 +0100 +++ b/rhodecode/model/permission.py Fri Jan 25 00:13:01 2013 +0100 @@ -118,8 +118,11 @@ for r2p in self.sa.query(UserRepoToPerm)\ .filter(UserRepoToPerm.user == perm_user)\ .all(): - r2p.permission = _def - self.sa.add(r2p) + + #don't reset PRIVATE repositories + if r2p.repository.private is False: + r2p.permission = _def + self.sa.add(r2p) if form_result['overwrite_default_group'] == True: _def_name = form_result['default_group_perm'].split('group.')[-1]