# HG changeset patch
# User Mads Kiilerich <madski@unity3d.com>
# Date 1362679581 -3600
# Node ID a2a61978752f3384ee71ea3c10b2ad096d836892
# Parent  ff3f10a6a2033ed6f0f7e5f48881ea9f8711fcf3
pullrequest: don't do in the ajax callback what can be done in no time right now

diff -r ff3f10a6a203 -r a2a61978752f rhodecode/templates/pullrequests/pullrequest.html
--- a/rhodecode/templates/pullrequests/pullrequest.html	Thu Mar 07 19:00:28 2013 +0100
+++ b/rhodecode/templates/pullrequests/pullrequest.html	Thu Mar 07 19:06:21 2013 +0100
@@ -156,29 +156,32 @@
       }
 
       YUD.get('pull_request_overview').innerHTML = "${_('Loading ...')}";
+      ypjax(url,'pull_request_overview');
+
       YUD.get('pull_request_overview_url').href = url; // shouldn't have as_form ... but ...
       YUD.setStyle(YUD.get('pull_request_overview_url').parentElement,'display','');
-      ypjax(url,'pull_request_overview', function(data){
-          var sel_box = YUQ('#pull_request_form #other_repo')[0];
-          var repo_name = sel_box.options[sel_box.selectedIndex].value;
-          YUD.get('other_repo_desc').innerHTML = other_repos_info[repo_name]['description'];
-          // replace options of other_ref with the ones for the current other_repo
-          var other_ref_selector = YUD.get('other_ref');
-          var new_select = YUD.createElementFromMarkup(other_repos_info[repo_name]['revs']);
-          var new_selectedIndex = new_select.selectedIndex;
-          other_ref_selector.innerHTML = ""; // clear old options
-          while (new_select.length > 0){ // children will be popped when appened to other_ref_selector
-              other_ref_selector.appendChild(new_select.children[0]);
-          }
-          // browsers lost track of selected when appendChild was used
-          other_ref_selector.selectedIndex = new_selectedIndex;
-          // reset && add the reviewer based on selected repo
-          var _data = other_repos_info[repo_name];
-          YUD.get('review_members').innerHTML = '';
-          addReviewMember(_data.user.user_id, _data.user.firstname,
-                          _data.user.lastname, _data.user.username,
-                          _data.user.gravatar_link);
-      })
+
+      var sel_box = YUQ('#pull_request_form #other_repo')[0];
+      var repo_name = sel_box.options[sel_box.selectedIndex].value;
+
+      YUD.get('other_repo_desc').innerHTML = other_repos_info[repo_name]['description'];
+      // replace options of other_ref with the ones for the current other_repo
+      var other_ref_selector = YUD.get('other_ref');
+      var new_select = YUD.createElementFromMarkup(other_repos_info[repo_name]['revs']);
+      var new_selectedIndex = new_select.selectedIndex;
+      other_ref_selector.innerHTML = ""; // clear old options
+      while (new_select.length > 0){ // children will be popped when appened to other_ref_selector
+          other_ref_selector.appendChild(new_select.children[0]);
+      }
+      // browsers lost track of selected when appendChild was used
+      other_ref_selector.selectedIndex = new_selectedIndex;
+
+      // reset && add the reviewer based on selected repo
+      var _data = other_repos_info[repo_name];
+      YUD.get('review_members').innerHTML = '';
+      addReviewMember(_data.user.user_id, _data.user.firstname,
+                      _data.user.lastname, _data.user.username,
+                      _data.user.gravatar_link);
   }
 
   ## refresh automatically when something changes (org_repo can't change)