# HG changeset patch # User Mads Kiilerich # Date 1456787798 -3600 # Node ID ba3bdd16ca2d83431655f1082bf08adb2d7aa90d # Parent bc6178c3b67b0e0e747c3c1e24f7e4dfded9b2d3 db: make return type for get_comments consistent - don't return a list for the empty case diff -r bc6178c3b67b -r ba3bdd16ca2d kallithea/model/db.py --- a/kallithea/model/db.py Wed Feb 10 12:01:22 2016 +0000 +++ b/kallithea/model/db.py Tue Mar 01 00:16:38 2016 +0100 @@ -1388,7 +1388,7 @@ .filter(ChangesetComment.repo == self) if revisions is not None: if not revisions: - return [] # don't use sql 'in' on empty set + return {} # don't use sql 'in' on empty set cmts = cmts.filter(ChangesetComment.revision.in_(revisions)) grouped = collections.defaultdict(list) for cmt in cmts.all():