# HG changeset patch
# User Mads Kiilerich <mads@kiilerich.com>
# Date 1609277448 -3600
# Node ID c76638100ca011fb4300ac60f41dee8439a30648
# Parent  1b683a4eb9fc724deda468bc0adcb1050a92845b
deps: also report unseen known violations

diff -r 1b683a4eb9fc -r c76638100ca0 scripts/deps.py
--- a/scripts/deps.py	Mon Dec 28 00:43:18 2020 +0100
+++ b/scripts/deps.py	Tue Dec 29 22:30:48 2020 +0100
@@ -153,7 +153,7 @@
 shown_modules = normal_modules | top_modules
 
 # break the chains somehow - this is a cleanup TODO list
-known_violations = [
+known_violations = set([
 ('kallithea.lib.auth_modules', 'kallithea.lib.auth'),  # needs base&facade
 ('kallithea.lib.utils', 'kallithea.model'),  # clean up utils
 ('kallithea.lib.utils', 'kallithea.model.db'),
@@ -166,7 +166,7 @@
 ('kallithea.model', 'kallithea.lib.hooks'),  # clean up hooks
 ('kallithea.model', 'kallithea.model.scm'),
 ('kallithea.model.scm', 'kallithea.lib.hooks'),
-]
+])
 
 extra_edges = [
 ('kallithea.config', 'kallithea.controllers'),  # through TG
@@ -271,6 +271,8 @@
 
     # verify dependencies by untangling dependency chain bottom-up:
     todo = set(normalized_dep_edges)
+    unseen_violations = known_violations.difference(todo)
+    assert not unseen_violations, unseen_violations
     for x in known_violations:
         todo.remove(x)