# HG changeset patch # User Thomas De Schampheleire # Date 1518424141 -3600 # Node ID cbfc29a4c363bf25b69a360d16d9183b9c46aab8 # Parent 8bea04f3d6d3c767a0b1bd859c566abd8cdf2492 email templates: add HTML entities to test strings An issue is observed in Outlook rendering of HTML emails, where the HTML entity ' is not recognized and seen as a literal string. Add some HTML entities to the test strings to be able to see the issue (after mailing the resulting HTML to an Outlook client) diff -r 8bea04f3d6d3 -r cbfc29a4c363 kallithea/tests/models/test_dump_html_mails.ref.html --- a/kallithea/tests/models/test_dump_html_mails.ref.html Thu Jan 11 15:50:07 2018 +0100 +++ b/kallithea/tests/models/test_dump_html_mails.ref.html Mon Feb 12 09:29:01 2018 +0100 @@ -17,7 +17,7 @@ Opinionated User (jsmith): -This is the new comment. +This is the new 'comment'. - and here it ends indented. @@ -94,7 +94,7 @@ -
This is the new comment.

- and here it ends indented.
+
This is the new 'comment'.

- and here it ends indented.
@@ -176,7 +176,7 @@ Opinionated User (jsmith): -This is the new comment. +This is the new 'comment'. - and here it ends indented. @@ -253,7 +253,7 @@ -
This is the new comment.

- and here it ends indented.
+
This is the new 'comment'.

- and here it ends indented.
@@ -337,7 +337,7 @@ Status change: Approved -This is the new comment. +This is the new 'comment'. - and here it ends indented. @@ -430,7 +430,7 @@ -
This is the new comment.

- and here it ends indented.
+
This is the new 'comment'.

- and here it ends indented.
@@ -514,7 +514,7 @@ Status change: Approved -This is the new comment. +This is the new 'comment'. - and here it ends indented. @@ -607,7 +607,7 @@ -
This is the new comment.

- and here it ends indented.
+
This is the new 'comment'.

- and here it ends indented.
@@ -682,7 +682,7 @@ Subject: Test Message
-
This is the body of the test message
+
This is the 'body' of the "test" message
  - nothing interesting here except indentation.

@@ -728,7 +728,7 @@ - +
This is the body of the test message
- nothing interesting here except indentation.
This is the 'body' of the "test" message
- nothing interesting here except indentation.
@@ -897,7 +897,7 @@ Description: -This PR is awesome because it does stuff +This PR is 'awesome' because it does - please approve indented! @@ -987,7 +987,7 @@ -
This PR is awesome because it does stuff
- please approve indented!
+
This PR is 'awesome' because it does <stuff>
- please approve indented!
@@ -1072,7 +1072,7 @@ Description: -This PR is awesome because it does stuff +This PR is 'awesome' because it does - please approve indented! @@ -1162,7 +1162,7 @@ -
This PR is awesome because it does stuff
- please approve indented!
+
This PR is 'awesome' because it does <stuff>
- please approve indented!
diff -r 8bea04f3d6d3 -r cbfc29a4c363 kallithea/tests/models/test_notifications.py --- a/kallithea/tests/models/test_notifications.py Thu Jan 11 15:50:07 2018 +0100 +++ b/kallithea/tests/models/test_notifications.py Mon Feb 12 09:29:01 2018 +0100 @@ -209,7 +209,7 @@ for type_, body, kwargs in [ (Notification.TYPE_CHANGESET_COMMENT, - u'This is the new comment.\n\n - and here it ends indented.', + u'This is the new \'comment\'.\n\n - and here it ends indented.', dict( short_id='cafe1234', raw_id='cafe1234c0ffeecafe', @@ -224,7 +224,7 @@ cs_url='http://changeset.com', cs_author=User.get(self.u2))), (Notification.TYPE_MESSAGE, - u'This is the body of the test message\n - nothing interesting here except indentation.', + u'This is the \'body\' of the "test" message\n - nothing interesting here except indentation.', dict()), #(Notification.TYPE_MENTION, '$body', None), # not used (Notification.TYPE_REGISTRATION, @@ -235,7 +235,7 @@ new_email='new@email.com', new_full_name='New Full Name')), (Notification.TYPE_PULL_REQUEST, - u'This PR is awesome because it does stuff\n - please approve indented!', + u'This PR is \'awesome\' because it does \n - please approve indented!', dict( pr_user_created='Requesting User (root)', # pr_owner should perhaps be used for @mention in description ... is_mention=[False, True],