# HG changeset patch
# User Mads Kiilerich <mads@kiilerich.com>
# Date 1535760495 -7200
# Node ID cc2f0cfd78679998cf7872f2f9d66dda0acc5471
# Parent  e44954828c9a50c6f9cae8bf1fd3a8a122ccf708
ishell: specify ipython minimum version 4

`gearbox ishell` has an "optional" dependency on ipython as it fails with:
  Kallithea ishell requires the IPython Python package
Before the previous change, after installing ipython < 4, it would however
still fail the same way.
With the previous change, it would fail in a slightly more helpful way with:
  ImportError: No module named traitlets.config.loader

With ipython < 4, after installing the missing traitlets (4.3.2) as hinted,
ishell still failed with:
  TraitError: The 'config' trait of an InteractiveShellEmbed instance must be a Config or None, but a value of class 'traitlets.config.loader.Config' (i.e. {'InteractiveShellEmbed': {'confirm_exit': False}}) was specified.

With ipython >= 4, traitlets is installed as dependency, and ishell works.
Tested with both ipython 4.0 and current latest version 5.8 .

Thus, just clarify that we only support ipython >= 4 .

diff -r e44954828c9a -r cc2f0cfd7867 kallithea/lib/paster_commands/ishell.py
--- a/kallithea/lib/paster_commands/ishell.py	Sat Sep 01 01:20:18 2018 +0200
+++ b/kallithea/lib/paster_commands/ishell.py	Sat Sep 01 02:08:15 2018 +0200
@@ -44,7 +44,7 @@
         try:
             from IPython import embed
         except ImportError:
-            print 'Kallithea ishell requires the IPython Python package'
+            print 'Kallithea ishell requires the Python package IPython 4 or later'
             sys.exit(-1)
         from traitlets.config.loader import Config
         cfg = Config()