# HG changeset patch # User Mads Kiilerich # Date 1430232905 -7200 # Node ID dd8459607c076b7b147eb52434d5c84e69ebe071 # Parent 53d6a64ce4f3000ed39aacc5f4c5ccbb52830006 permissions: small template/javascript refactorings diff -r 53d6a64ce4f3 -r dd8459607c07 kallithea/templates/base/perms_summary.html --- a/kallithea/templates/base/perms_summary.html Tue Apr 28 16:55:05 2015 +0200 +++ b/kallithea/templates/base/perms_summary.html Tue Apr 28 16:55:05 2015 +0200 @@ -11,8 +11,8 @@ %if section != 'global':
${_('show')}: - ${h.checkbox('perms_filter_none_%s' % section, 'none', 'checked', class_='perm_filter filter_%s' % section, section=section, perm_type='none')} - ${h.checkbox('perms_filter_read_%s' % section, 'read', 'checked', class_='perm_filter filter_%s' % section, section=section, perm_type='read')} + ${h.checkbox('perms_filter_none_%s' % section, 'none', 'checked', class_='perm_filter filter_%s' % section, section=section, perm_type='none')} + ${h.checkbox('perms_filter_read_%s' % section, 'read', 'checked', class_='perm_filter filter_%s' % section, section=section, perm_type='read')} ${h.checkbox('perms_filter_write_%s' % section, 'write', 'checked', class_='perm_filter filter_%s' % section, section=section, perm_type='write')} ${h.checkbox('perms_filter_admin_%s' % section, 'admin', 'checked', class_='perm_filter filter_%s' % section, section=section, perm_type='admin')}
@@ -108,15 +108,12 @@ $('#empty_{0}'.format(section)).hide(); } } - $('.perm_filter').on('change', function(e){ - var self = this; - var section = $(this).attr('section'); + var update_show = function($checkbox){ + var section = $checkbox.attr('section'); - var opts = {} var elems = $('.filter_' + section).each(function(el){ - var perm_type = $(this).attr('perm_type'); - var checked = this.checked; - opts[perm_type] = checked; + var perm_type = $checkbox.attr('perm_type'); + var checked = $checkbox.checked; if(checked){ $('.'+section+'_'+perm_type).show(); } @@ -125,8 +122,8 @@ } }); show_empty(section); - }) - + } + $('.perm_filter').on('change', function(){update_show($(this));}); })