# HG changeset patch # User Mads Kiilerich # Date 1566150649 -7200 # Node ID e6b9194ab3f8152326258c8fc0214ae78e7e8d66 # Parent 52637097d62f793c09f37eb0af0c253edeb39710 scm: select options should be tuples - not lists with 2 elements We use tuples in all(?) other places, so we should do the same here. Since lists can be unpacked as tuples, it currently works to use 2-lists. But in a following change for "correct" handling of webhelpers.select when using webhelpers2.select, we want to give special handling to tuples vs strings vs Options. We don't want to add list to that list. diff -r 52637097d62f -r e6b9194ab3f8 kallithea/model/scm.py --- a/kallithea/model/scm.py Sun Aug 18 18:33:35 2019 +0200 +++ b/kallithea/model/scm.py Sun Aug 18 19:50:49 2019 +0200 @@ -665,7 +665,7 @@ hist_l = [] choices = [] repo = self.__get_repo(repo) - hist_l.append(['rev:tip', _('latest tip')]) + hist_l.append(('rev:tip', _('latest tip'))) choices.append('rev:tip') if repo is None: return choices, hist_l