# HG changeset patch # User Marcin Kuzminski # Date 1350683075 -7200 # Node ID f53faff4487ed10558fc4311d418327ec4b7dbaf # Parent d0c2299d08d4ca0cd51a56942da5373b95d361aa get_or_404 method does validation for ID beeing an INT diff -r d0c2299d08d4 -r f53faff4487e rhodecode/model/db.py --- a/rhodecode/model/db.py Fri Oct 19 23:39:43 2012 +0200 +++ b/rhodecode/model/db.py Fri Oct 19 23:44:35 2012 +0200 @@ -118,11 +118,15 @@ @classmethod def get_or_404(cls, id_): - if id_: - res = cls.query().get(id_) - if not res: - raise HTTPNotFound - return res + try: + id_ = int(id_) + except (TypeError, ValueError): + raise HTTPNotFound + + res = cls.query().get(id_) + if not res: + raise HTTPNotFound + return res @classmethod def getAll(cls):