# HG changeset patch # User Mads Kiilerich # Date 1538324995 -7200 # Node ID fb493f3ed4e3048055c1800db9f93c65b3a92e54 # Parent 618f2158562e3c1715b7abb3eaaca32ac29d2a71 tests: fix vcs Hg helper functions get_user_name and get_user_email to actually use provided config_file Running just test_get_user_name and test_get_user_email would fail when run as: py.test kallithea/tests/vcs/test_repository.py -k test_get_user The config file was not used at all, and the tests would only pass when test_get_config_value had been run first and as an unfortunate side-effect had read the same file. diff -r 618f2158562e -r fb493f3ed4e3 kallithea/lib/vcs/backends/hg/repository.py --- a/kallithea/lib/vcs/backends/hg/repository.py Sun Sep 16 21:05:06 2018 +0200 +++ b/kallithea/lib/vcs/backends/hg/repository.py Sun Sep 30 18:29:55 2018 +0200 @@ -613,7 +613,7 @@ :param config_file: A path to file which should be used to retrieve configuration from (might also be a list of file paths) """ - username = self.get_config_value('ui', 'username') + username = self.get_config_value('ui', 'username', config_file=config_file) if username: return author_name(username) return None @@ -625,7 +625,7 @@ :param config_file: A path to file which should be used to retrieve configuration from (might also be a list of file paths) """ - username = self.get_config_value('ui', 'username') + username = self.get_config_value('ui', 'username', config_file=config_file) if username: return author_email(username) return None