Mercurial > kallithea

changeset 4434:00c76c4e019c

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
pull request: make it more visible that reviewers only are added/removed after save
author Mads Kiilerich <madski@unity3d.com>
date Tue, 12 Aug 2014 13:08:23 +0200
parents dacbd7f15ba2
children c35429c32d7f
files kallithea/public/js/base.js
diffstat 1 files changed, 5 insertions(+), 2 deletions(-) [+]
line wrap: on
line diff
--- a/kallithea/public/js/base.js	Tue Aug 12 13:08:23 2014 +0200
+++ b/kallithea/public/js/base.js	Tue Aug 12 13:08:23 2014 +0200
@@ -1502,7 +1502,7 @@
         '         <input type="hidden" value="{2}" name="review_members" />\n'+
         '         <div class="reviewer_member_remove action_button" onclick="removeReviewMember({2})">\n'+
         '             <i class="icon-remove-sign" style="color: #FF4444;"></i>\n'+
-        '         </div>\n'+
+        '         </div> *\n'+
         '       </div>\n'+
         '     </li>\n'
         ).format(gravatar_link, displayname, id);
@@ -1518,7 +1518,10 @@
 }
 
 var removeReviewMember = function(reviewer_id, repo_name, pull_request_id){
-    $('#reviewer_{0}'.format(reviewer_id)).remove();
+    var $li = $('#reviewer_{0}'.format(reviewer_id));
+    $li.find('div div').css("text-decoration", "line-through");
+    $li.find('input').remove();
+    $li.find('.reviewer_member_remove').remove();
 }
 
 /* handle "Save Changes" of addReviewMember and removeReviewMember on PR */