Mercurial > kallithea
changeset 3619:03028bf372d7 beta
missing changesets should return 404 not redirect + flash.
It feels more correct.
| author | Marcin Kuzminski <marcin@python-works.com> |
|---|---|
| date | Wed, 27 Mar 2013 19:38:05 +0100 |
| parents | 0e18540fd1c7 |
| children | a2afaf84330c |
| files | rhodecode/controllers/changeset.py rhodecode/templates/errors/error_document.html |
| diffstat | 2 files changed, 12 insertions(+), 12 deletions(-) [+] |
line wrap: on
line diff
--- a/rhodecode/controllers/changeset.py Wed Mar 27 19:37:14 2013 +0100 +++ b/rhodecode/controllers/changeset.py Wed Mar 27 19:38:05 2013 +0100 @@ -26,7 +26,7 @@ import logging import traceback from collections import defaultdict -from webob.exc import HTTPForbidden, HTTPBadRequest +from webob.exc import HTTPForbidden, HTTPBadRequest, HTTPNotFound from pylons import tmpl_context as c, url, request, response from pylons.i18n.translation import _ @@ -204,7 +204,7 @@ except (RepositoryError, ChangesetDoesNotExistError, Exception), e: log.error(traceback.format_exc()) h.flash(str(e), category='error') - return redirect(url('changeset_home', repo_name=c.repo_name)) + raise HTTPNotFound() c.changes = OrderedDict()
--- a/rhodecode/templates/errors/error_document.html Wed Mar 27 19:37:14 2013 +0100 +++ b/rhodecode/templates/errors/error_document.html Wed Mar 27 19:38:05 2013 +0100 @@ -33,16 +33,16 @@ </head> <body> - <div class="flash_msg"> - <% messages = h.flash.pop_messages() %> - % if messages: - <ul id="flash-messages"> - % for message in messages: - <li class="${message.category}_msg">${message}</li> - % endfor - </ul> - % endif - </div> + <div class="flash_msg"> + <% messages = h.flash.pop_messages() %> + % if messages: + <ul id="flash-messages"> + % for message in messages: + <li class="${message.category}_msg">${message}</li> + % endfor + </ul> + % endif + </div> <div id="login"> <div class="table"> <div id="main_div">