Mercurial > kallithea

changeset 7427:0dac14c83d9f

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
controllers: pullrequests: rename _get_is_allowed_change_status Rename the oddly named method '_get_is_allowed_change_status' to '_is_allowed_to_change_status'. Not only does this read more easily, but also it is more in line with the variable to which the result is assigned to 'allowed_to_change_status'.
author Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
date Sat, 10 Nov 2018 21:29:29 +0100
parents b58113063bb2
children 9de5c174a37c
files kallithea/controllers/pullrequests.py
diffstat 1 files changed, 3 insertions(+), 3 deletions(-) [+]
line wrap: on
line diff
--- a/kallithea/controllers/pullrequests.py	Sat Nov 10 21:05:28 2018 +0100
+++ b/kallithea/controllers/pullrequests.py	Sat Nov 10 21:29:29 2018 +0100
@@ -186,7 +186,7 @@
                   ]
         return [g for g in groups if g[0]], selected
 
-    def _get_is_allowed_change_status(self, pull_request):
+    def _is_allowed_to_change_status(self, pull_request):
         if pull_request.is_closed():
             return False
 
@@ -453,7 +453,7 @@
         repo_model = RepoModel()
         c.users_array = repo_model.get_users_js()
         c.pull_request = PullRequest.get_or_404(pull_request_id)
-        c.allowed_to_change_status = self._get_is_allowed_change_status(c.pull_request)
+        c.allowed_to_change_status = self._is_allowed_to_change_status(c.pull_request)
         cc_model = ChangesetCommentsModel()
         cs_model = ChangesetStatusModel()
 
@@ -644,7 +644,7 @@
             # status votes and closing is only possible in general comments
             raise HTTPBadRequest()
 
-        allowed_to_change_status = self._get_is_allowed_change_status(pull_request)
+        allowed_to_change_status = self._is_allowed_to_change_status(pull_request)
         if not allowed_to_change_status:
             if status or close_pr:
                 h.flash(_('No permission to change pull request status'), 'error')