Mercurial > kallithea

changeset 8037:1522a33ac21f

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
vcs: drop unused _diff_name_status It popped up as something to do for py3. Don't waste time on it.
author Mads Kiilerich <mads@kiilerich.com>
date Thu, 26 Dec 2019 00:14:46 +0100
parents e7b6a0ce123c
children ed08a2117d8f
files kallithea/lib/vcs/backends/git/changeset.py kallithea/tests/vcs/test_git.py
diffstat 2 files changed, 0 insertions(+), 34 deletions(-) [+]
line wrap: on
line diff
--- a/kallithea/lib/vcs/backends/git/changeset.py	Fri Dec 27 01:43:46 2019 +0100
+++ b/kallithea/lib/vcs/backends/git/changeset.py	Thu Dec 26 00:14:46 2019 +0100
@@ -494,16 +494,6 @@
         return list(added.union(modified).union(deleted))
 
     @LazyProperty
-    def _diff_name_status(self):
-        output = []
-        for parent in self.parents:
-            cmd = ['diff', '--name-status', parent.raw_id, self.raw_id,
-                   '--encoding=utf8']
-            so, se = self.repository.run_git_command(cmd)
-            output.append(so.strip())
-        return '\n'.join(output)
-
-    @LazyProperty
     def _changes_cache(self):
         added = set()
         modified = set()
--- a/kallithea/tests/vcs/test_git.py	Fri Dec 27 01:43:46 2019 +0100
+++ b/kallithea/tests/vcs/test_git.py	Thu Dec 26 00:14:46 2019 +0100
@@ -620,30 +620,6 @@
         assert 'marcink none@none' == self.repo.get_changeset('8430a588b43b5d6da365400117c89400326e7992').author_name
 
 
-class TestGitSpecific():
-
-    def test_error_is_raised_for_added_if_diff_name_status_is_wrong(self):
-        repo = mock.MagicMock()
-        changeset = GitChangeset(repo, 'foobar')
-        changeset._diff_name_status = 'foobar'
-        with pytest.raises(VCSError):
-            changeset.added
-
-    def test_error_is_raised_for_changed_if_diff_name_status_is_wrong(self):
-        repo = mock.MagicMock()
-        changeset = GitChangeset(repo, 'foobar')
-        changeset._diff_name_status = 'foobar'
-        with pytest.raises(VCSError):
-            changeset.added
-
-    def test_error_is_raised_for_removed_if_diff_name_status_is_wrong(self):
-        repo = mock.MagicMock()
-        changeset = GitChangeset(repo, 'foobar')
-        changeset._diff_name_status = 'foobar'
-        with pytest.raises(VCSError):
-            changeset.added
-
-
 class TestGitSpecificWithRepo(_BackendTestMixin):
     backend_alias = 'git'