Mercurial > kallithea

changeset 4427:1ffa190f686a

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
pull requests: don't allow status change on closed PRs - aba28699ec41 was pushed prematurely
author Mads Kiilerich <madski@unity3d.com>
date Tue, 12 Aug 2014 13:08:23 +0200
parents e172e98f3e35
children 0e60c5bb34f0
files kallithea/controllers/pullrequests.py
diffstat 1 files changed, 3 insertions(+), 0 deletions(-) [+]
line wrap: on
line diff
--- a/kallithea/controllers/pullrequests.py	Tue Aug 12 13:08:23 2014 +0200
+++ b/kallithea/controllers/pullrequests.py	Tue Aug 12 13:08:23 2014 +0200
@@ -184,6 +184,9 @@
         return [g for g in groups if g[0]], selected
 
     def _get_is_allowed_change_status(self, pull_request):
+        if pull_request.is_closed():
+            return False
+
         owner = self.authuser.user_id == pull_request.user_id
         reviewer = self.authuser.user_id in [x.user_id for x in
                                                    pull_request.reviewers]