Mercurial > kallithea

changeset 3750:244f184f5fc3 beta

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
moved around some code in changeset controllers to properly log which function was decorated. Before it was always index, and permission were checked twice giving unnneded overhead
author Marcin Kuzminski <marcin@python-works.com>
date Mon, 15 Apr 2013 01:01:47 +0200
parents b950b884ab87
children 78c7e8efe658
files rhodecode/controllers/changeset.py
diffstat 1 files changed, 10 insertions(+), 7 deletions(-) [+]
line wrap: on
line diff
--- a/rhodecode/controllers/changeset.py	Mon Apr 15 00:46:34 2013 +0200
+++ b/rhodecode/controllers/changeset.py	Mon Apr 15 01:01:47 2013 +0200
@@ -177,10 +177,7 @@
         c.users_array = repo_model.get_users_js()
         c.users_groups_array = repo_model.get_users_groups_js()
 
-    @LoginRequired()
-    @HasRepoPermissionAnyDecorator('repository.read', 'repository.write',
-                                   'repository.admin')
-    def index(self, revision, method='show'):
+    def _index(self, revision, method):
         c.anchor_url = anchor_url
         c.ignorews_url = _ignorews_url
         c.context_url = _context_url
@@ -315,20 +312,26 @@
     @LoginRequired()
     @HasRepoPermissionAnyDecorator('repository.read', 'repository.write',
                                    'repository.admin')
+    def index(self, revision, method='show'):
+        return self._index(revision, method=method)
+
+    @LoginRequired()
+    @HasRepoPermissionAnyDecorator('repository.read', 'repository.write',
+                                   'repository.admin')
     def changeset_raw(self, revision):
-        return self.index(revision, method='raw')
+        return self._index(revision, method='raw')
 
     @LoginRequired()
     @HasRepoPermissionAnyDecorator('repository.read', 'repository.write',
                                    'repository.admin')
     def changeset_patch(self, revision):
-        return self.index(revision, method='patch')
+        return self._index(revision, method='patch')
 
     @LoginRequired()
     @HasRepoPermissionAnyDecorator('repository.read', 'repository.write',
                                    'repository.admin')
     def changeset_download(self, revision):
-        return self.index(revision, method='download')
+        return self._index(revision, method='download')
 
     @LoginRequired()
     @NotAnonymous()