Mercurial > kallithea

changeset 7429:471b29a2f302

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
model: changeset_status: remove support for 'dont_allow_on_closed_pull_request' and 'StatusChangeOnClosedPullRequestError' Previous commit removed the only usage of this parameter and exception.
author Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
date Sat, 10 Nov 2018 21:35:54 +0100
parents 9de5c174a37c
children aee1f11faa8c
files kallithea/lib/exceptions.py kallithea/model/changeset_status.py
diffstat 2 files changed, 1 insertions(+), 18 deletions(-) [+]
line wrap: on
line diff
--- a/kallithea/lib/exceptions.py	Sat Nov 10 21:34:57 2018 +0100
+++ b/kallithea/lib/exceptions.py	Sat Nov 10 21:35:54 2018 +0100
@@ -59,10 +59,6 @@
     pass
 
 
-class StatusChangeOnClosedPullRequestError(Exception):
-    pass
-
-
 class AttachedForksError(Exception):
     pass
 
--- a/kallithea/model/changeset_status.py	Sat Nov 10 21:34:57 2018 +0100
+++ b/kallithea/model/changeset_status.py	Sat Nov 10 21:35:54 2018 +0100
@@ -29,7 +29,6 @@
 from sqlalchemy.orm import joinedload
 
 from kallithea.model.db import ChangesetStatus, PullRequest, Repository, User, Session
-from kallithea.lib.exceptions import StatusChangeOnClosedPullRequestError
 
 log = logging.getLogger(__name__)
 
@@ -133,7 +132,7 @@
         return status
 
     def set_status(self, repo, status, user, comment, revision=None,
-                   pull_request=None, dont_allow_on_closed_pull_request=False):
+                   pull_request=None):
         """
         Creates new status for changeset or updates the old ones bumping their
         version, leaving the current status at the value of 'status'.
@@ -144,9 +143,6 @@
         :param comment:
         :param revision:
         :param pull_request:
-        :param dont_allow_on_closed_pull_request: don't allow a status change
-            if last status was for pull request and it's closed. We shouldn't
-            mess around this manually
         """
         repo = Repository.guess_instance(repo)
 
@@ -165,15 +161,6 @@
             revisions = pull_request.revisions
         cur_statuses = q.all()
 
-        # if statuses exists and last is associated with a closed pull request
-        # we need to check if we can allow this status change
-        if (dont_allow_on_closed_pull_request and cur_statuses
-            and getattr(cur_statuses[0].pull_request, 'status', '')
-                == PullRequest.STATUS_CLOSED):
-            raise StatusChangeOnClosedPullRequestError(
-                'Changing status on closed pull request is not allowed'
-            )
-
         # update all current statuses with older version
         for st in cur_statuses:
             st.version += 1