Mercurial > kallithea
changeset 8074:4780af2c6ff2
api: better error logging for API usage errors - say which request failed to encode response
author | Mads Kiilerich <mads@kiilerich.com> |
---|---|
date | Fri, 27 Dec 2019 01:50:40 +0100 |
parents | 67eeb02062fe |
children | c7d1efd3ca3f |
files | kallithea/controllers/api/__init__.py kallithea/controllers/api/api.py |
diffstat | 2 files changed, 2 insertions(+), 2 deletions(-) [+] |
line wrap: on
line diff
--- a/kallithea/controllers/api/__init__.py Sat Dec 21 15:55:51 2019 +0100 +++ b/kallithea/controllers/api/__init__.py Fri Dec 27 01:50:40 2019 +0100 @@ -240,7 +240,7 @@ try: return json.dumps(response) except TypeError as e: - log.error('API FAILED. Error encoding response: %s', e) + log.error('API FAILED. Error encoding response for %s %s: %s\n%s', action, rpc_args, e, traceback.format_exc()) return json.dumps( dict( id=self._req_id,
--- a/kallithea/controllers/api/api.py Sat Dec 21 15:55:51 2019 +0100 +++ b/kallithea/controllers/api/api.py Fri Dec 27 01:50:40 2019 +0100 @@ -2400,7 +2400,7 @@ pull_request=pull_request.pull_request_id, f_path=None, line_no=None, - status_change=(ChangesetStatus.get_status_lbl(status)), + status_change=ChangesetStatus.get_status_lbl(status), closing_pr=close_pr ) action_logger(apiuser,