changeset 6454:4aaeac1e7ba3

refactor: drop some irrelevant x = x assignments
author Mads Kiilerich <mads@kiilerich.com>
date Sun, 22 Jan 2017 01:16:52 +0100
parents ebe7d95f698b
children f19d8fd8e35a
files kallithea/controllers/files.py kallithea/controllers/pullrequests.py kallithea/lib/utils.py kallithea/model/repo_group.py
diffstat 4 files changed, 3 insertions(+), 8 deletions(-) [+]
line wrap: on
line diff
--- a/kallithea/controllers/files.py	Sun Jan 22 01:16:52 2017 +0100
+++ b/kallithea/controllers/files.py	Sun Jan 22 01:16:52 2017 +0100
@@ -204,7 +204,6 @@
     @jsonify
     def history(self, repo_name, revision, f_path):
         changeset = self.__get_cs(revision)
-        f_path = f_path
         _file = changeset.get_node(f_path)
         if _file.is_file():
             file_history, _hist = self._get_node_history(changeset, f_path)
@@ -227,7 +226,6 @@
                                    'repository.admin')
     def authors(self, repo_name, revision, f_path):
         changeset = self.__get_cs(revision)
-        f_path = f_path
         _file = changeset.get_node(f_path)
         if _file.is_file():
             file_history, _hist = self._get_node_history(changeset, f_path)
--- a/kallithea/controllers/pullrequests.py	Sun Jan 22 01:16:52 2017 +0100
+++ b/kallithea/controllers/pullrequests.py	Sun Jan 22 01:16:52 2017 +0100
@@ -613,7 +613,6 @@
          c.a_rev) = c.pull_request.other_ref.split(':') # a_rev is ancestor
 
         org_scm_instance = c.cs_repo.scm_instance # property with expensive cache invalidation check!!!
-        c.cs_repo = c.cs_repo
         try:
             c.cs_ranges = [org_scm_instance.get_changeset(x)
                            for x in c.pull_request.revisions]
--- a/kallithea/lib/utils.py	Sun Jan 22 01:16:52 2017 +0100
+++ b/kallithea/lib/utils.py	Sun Jan 22 01:16:52 2017 +0100
@@ -595,8 +595,6 @@
     from kallithea.lib.indexers.daemon import WhooshIndexingDaemon
     from kallithea.lib.pidlock import DaemonLock, LockHeld
 
-    repo_location = repo_location
-
     index_location = os.path.join(config['app_conf']['index_dir'])
     if not os.path.exists(index_location):
         os.makedirs(index_location)
--- a/kallithea/model/repo_group.py	Sun Jan 22 01:16:52 2017 +0100
+++ b/kallithea/model/repo_group.py	Sun Jan 22 01:16:52 2017 +0100
@@ -240,7 +240,7 @@
             # iterated obj is an instance of a repos group or repository in
             # that group, recursive option can be: none, repos, groups, all
             if recursive == 'all':
-                obj = obj
+                pass
             elif recursive == 'repos':
                 # skip groups, other than this one
                 if isinstance(obj, RepoGroup) and not obj == repo_group:
@@ -346,7 +346,7 @@
             # iterated obj is an instance of a repos group or repository in
             # that group, recursive option can be: none, repos, groups, all
             if recursive == 'all':
-                el = el
+                pass
             elif recursive == 'repos':
                 # skip groups, other than this one
                 if isinstance(el, RepoGroup) and not el == repo_group:
@@ -401,7 +401,7 @@
             # iterated obj is an instance of a repos group or repository in
             # that group, recursive option can be: none, repos, groups, all
             if recursive == 'all':
-                el = el
+                pass
             elif recursive == 'repos':
                 # skip groups, other than this one
                 if isinstance(el, RepoGroup) and not el == repo_group: