Mercurial > kallithea
changeset 8927:5572eb8d4feb stable
html: clarify type of button elements - make it clear if we really want "submit"
This might fix some real problems.
author | Mads Kiilerich <mads@kiilerich.com> |
---|---|
date | Mon, 27 Jun 2022 20:50:23 +0200 |
parents | cc70797e70e1 |
children | 0f9415c2115e |
files | kallithea/public/js/base.js kallithea/templates/admin/user_groups/user_group_edit_perms.html kallithea/templates/changeset/diff_block.html kallithea/templates/data_table/_dt_elements.html |
diffstat | 4 files changed, 8 insertions(+), 6 deletions(-) [+] |
line wrap: on
line diff
--- a/kallithea/public/js/base.js Mon Jun 27 20:30:00 2022 +0200 +++ b/kallithea/public/js/base.js Mon Jun 27 20:50:23 2022 +0200 @@ -677,6 +677,7 @@ 'class': 'btn-group' }).append( $('<button>', { + 'type': 'button', 'class': 'btn btn-default btn-xs', text: _TM['Retry'] }).click(function() { @@ -685,6 +686,7 @@ ajaxPOST(AJAX_COMMENT_URL, postData, success, failure); }), $('<button>', { + 'type': 'button', 'class': 'btn btn-default btn-xs', text: _TM['Cancel'] }).click(function() {
--- a/kallithea/templates/admin/user_groups/user_group_edit_perms.html Mon Jun 27 20:30:00 2022 +0200 +++ b/kallithea/templates/admin/user_groups/user_group_edit_perms.html Mon Jun 27 20:50:23 2022 +0200 @@ -67,7 +67,7 @@ %endif </td> <td> - <button class="btn btn-default btn-xs" onclick="ajaxActionRevoke(${g2p.user_group.users_group_id}, 'user_group', '${'id%s'%id(g2p.user_group.users_group_name)}', '${g2p.user_group.users_group_name}')"> + <button type="button" class="btn btn-default btn-xs" onclick="ajaxActionRevoke(${g2p.user_group.users_group_id}, 'user_group', '${'id%s'%id(g2p.user_group.users_group_name)}', '${g2p.user_group.users_group_name}')"> <i class="icon-minus-circled"></i>${_('Revoke')} </button> </td>
--- a/kallithea/templates/changeset/diff_block.html Mon Jun 27 20:30:00 2022 +0200 +++ b/kallithea/templates/changeset/diff_block.html Mon Jun 27 20:50:23 2022 +0200 @@ -4,7 +4,7 @@ cs_repo_name, cs_ref_name, cs_ref_type, cs_rev, file_diff_data)"> <div class="diff-collapse"> - <button data-target="${'diff-container-%s' % (id(file_diff_data))}" class="diff-collapse-button btn btn-link btn-sm">↑ ${_('Collapse Diff')} ↑</button> + <button type='button', data-target="${'diff-container-%s' % (id(file_diff_data))}" class="diff-collapse-button btn btn-link btn-sm">↑ ${_('Collapse Diff')} ↑</button> </div> %for id_fid, url_fid, op, a_filename, cs_filename, diff, stats in file_diff_data: ${diff_block_diffblock(id_fid, url_fid, op, diff,
--- a/kallithea/templates/data_table/_dt_elements.html Mon Jun 27 20:30:00 2022 +0200 +++ b/kallithea/templates/data_table/_dt_elements.html Mon Jun 27 20:50:23 2022 +0200 @@ -70,7 +70,7 @@ <i class="icon-pencil"></i>${_('Edit')} </a> ${webutils.form(webutils.url('delete_repo', repo_name=repo_name))} - <button name="${'remove_%s' % repo_name}" class="btn btn-default btn-xs" + <button type="submit" name="${'remove_%s' % repo_name}" class="btn btn-default btn-xs" onclick="return confirm('${_('Confirm to delete this repository: %s') % repo_name}');"> <i class="icon-trashcan"></i>${_('Delete')} </button> @@ -92,7 +92,7 @@ <i class="icon-pencil"></i>${_('Edit')} </a> ${webutils.form(webutils.url('delete_user', id=user_id))} - <button id="${'remove_user_%s' % user_id}" name="${'remove_user_%s' % repo_name}" class="btn btn-default btn-xs" title="${_('Delete')}" + <button type="submit" id="${'remove_user_%s' % user_id}" name="${'remove_user_%s' % repo_name}" class="btn btn-default btn-xs" title="${_('Delete')}" onclick="return confirm('${_('Confirm to delete this user: %s') % username}');"> <i class="icon-trashcan"></i>${_('Delete')} </button> @@ -104,7 +104,7 @@ <i class="icon-pencil"></i>${_('Edit')} </a> ${webutils.form(webutils.url('delete_users_group', id=user_group_id))} - <button id="${'remove_group_%s' % user_group_id}" name="${'remove_user_%s' % repo_name}" class="btn btn-default btn-xs" title="${_('Delete')}" + <button type="submit" id="${'remove_group_%s' % user_group_id}" name="${'remove_user_%s' % repo_name}" class="btn btn-default btn-xs" title="${_('Delete')}" onclick="return confirm('${_('Confirm to delete this user group: %s') % user_group_name}');"> <i class="icon-trashcan"></i>${_('Delete')} </button> @@ -123,7 +123,7 @@ <i class="icon-pencil"></i>${_('Edit')} </a> ${webutils.form(webutils.url('delete_repo_group', group_name=repo_group_name))} - <button id="${'remove_%s' % repo_group_name}" name="${'remove_%s' % repo_group_name}" class="btn btn-default btn-xs" title="${_('Delete')}" + <button type="submit" id="${'remove_%s' % repo_group_name}" name="${'remove_%s' % repo_group_name}" class="btn btn-default btn-xs" title="${_('Delete')}" onclick="return confirm('${ungettext('Confirm to delete this group: %s with %s repository','Confirm to delete this group: %s with %s repositories',gr_count) % (repo_group_name, gr_count)}')"> <i class="icon-trashcan"></i>${_('Delete')} </button>