changeset 8332:58fc0c63ce55

tests: drop redundant User.get_default_user().username - default user is defined through the username
author Mads Kiilerich <mads@kiilerich.com>
date Mon, 30 Mar 2020 17:34:00 +0200
parents d5c7930e3d5a
children e505395c3a03
files kallithea/tests/api/api_base.py
diffstat 1 files changed, 4 insertions(+), 5 deletions(-) [+]
line wrap: on
line diff
--- a/kallithea/tests/api/api_base.py	Mon Mar 30 16:44:10 2020 +0200
+++ b/kallithea/tests/api/api_base.py	Mon Mar 30 17:34:00 2020 +0200
@@ -106,7 +106,6 @@
         Session().commit()
         cls.TEST_USER_LOGIN = cls.test_user.username
         cls.apikey_regular = cls.test_user.api_key
-        cls.default_user_username = User.get_default_user().username
 
     @classmethod
     def teardown_class(cls):
@@ -706,7 +705,7 @@
 
     def test_api_get_repo_by_non_admin_no_permission_to_repo(self):
         RepoModel().grant_user_permission(repo=self.REPO,
-                                          user=self.default_user_username,
+                                          user=User.DEFAULT_USER,
                                           perm='repository.none')
         try:
             RepoModel().grant_user_permission(repo=self.REPO,
@@ -721,7 +720,7 @@
             self._compare_error(id_, expected, given=response.body)
         finally:
             RepoModel().grant_user_permission(repo=self.REPO,
-                                              user=self.default_user_username,
+                                              user=User.DEFAULT_USER,
                                               perm='repository.read')
 
     def test_api_get_repo_that_doesn_not_exist(self):
@@ -1363,7 +1362,7 @@
 
     def test_api_fork_repo_non_admin_no_permission_to_fork(self):
         RepoModel().grant_user_permission(repo=self.REPO,
-                                          user=self.default_user_username,
+                                          user=User.DEFAULT_USER,
                                           perm='repository.none')
         try:
             fork_name = 'api-repo-fork'
@@ -1376,7 +1375,7 @@
             self._compare_error(id_, expected, given=response.body)
         finally:
             RepoModel().grant_user_permission(repo=self.REPO,
-                                              user=self.default_user_username,
+                                              user=User.DEFAULT_USER,
                                               perm='repository.read')
             fixture.destroy_repo(fork_name)