Mercurial > kallithea
changeset 5241:67ff34c2dcfb
autocomplete: remove redundant specification of responseSchema
YAHOO.util.DataSource.responseSchema determines which fields from the data
source are returned upon requests. In the case of user/group autocompletion,
the data source is a static JavaScript array containing only the relevant
fields. When not specifying a responseSchema, all fields of the selected
entry are returned, which is fine (in fact, the responseSchema currently
specified just mentions all fields, redundantly).
| author | Thomas De Schampheleire <thomas.de.schampheleire@gmail.com> |
|---|---|
| date | Tue, 30 Jun 2015 17:55:09 +0200 |
| parents | e2f9a14a54e0 |
| children | a5b32cea5c03 |
| files | kallithea/public/js/base.js |
| diffstat | 1 files changed, 0 insertions(+), 14 deletions(-) [+] |
line wrap: on
line diff
--- a/kallithea/public/js/base.js Fri Jun 26 22:13:42 2015 +0200 +++ b/kallithea/public/js/base.js Tue Jun 30 17:55:09 2015 +0200 @@ -1243,15 +1243,9 @@ // DataScheme for members var memberDS = new YAHOO.util.FunctionDataSource(matchAll); - memberDS.responseSchema = { - fields: ["id", "fname", "lname", "nname", "grname", "grmembers", "gravatar_lnk", "gravatar_size"] - }; // DataScheme for owner var ownerDS = new YAHOO.util.FunctionDataSource(matchUsers); - ownerDS.responseSchema = { - fields: ["id", "fname", "lname", "nname", "gravatar_lnk", "gravatar_size"] - }; // Instantiate AutoComplete for perms var membersAC = new YAHOO.widget.AutoComplete(divid, cont, memberDS); @@ -1309,10 +1303,6 @@ // DataScheme for owner var ownerDS = new YAHOO.util.FunctionDataSource(matchUsers); - ownerDS.responseSchema = { - fields: ["id", "fname", "lname", "nname", "gravatar_lnk", "gravatar_size"] - }; - // Instantiate AutoComplete for mentions var ownerAC = new YAHOO.widget.AutoComplete(divid, cont, ownerDS); ownerAC.useShadow = false; @@ -1446,10 +1436,6 @@ // DataScheme for owner var ownerDS = new YAHOO.util.FunctionDataSource(matchUsers); - ownerDS.responseSchema = { - fields: ["id", "fname", "lname", "nname", "gravatar_lnk", "gravatar_size"] - }; - // Instantiate AutoComplete for mentions var reviewerAC = new YAHOO.widget.AutoComplete(divid, cont, ownerDS); reviewerAC.useShadow = false;