Mercurial > kallithea
changeset 5568:737c3704b44a stable
cleanup: fixes of checking for None
Don't update repoinfo for all repos if an invalid repo is specified.
| author | Mads Kiilerich <madski@unity3d.com> |
|---|---|
| date | Sat, 07 Nov 2015 13:16:58 +0100 |
| parents | b428b05e5cea |
| children | ebc4cc82cce2 7425088bc4ff |
| files | kallithea/lib/paster_commands/update_repoinfo.py kallithea/lib/vcs/backends/git/changeset.py kallithea/lib/vcs/backends/hg/changeset.py kallithea/model/repo.py |
| diffstat | 4 files changed, 4 insertions(+), 4 deletions(-) [+] |
line wrap: on
line diff
--- a/kallithea/lib/paster_commands/update_repoinfo.py Sat Nov 07 13:16:57 2015 +0100 +++ b/kallithea/lib/paster_commands/update_repoinfo.py Sat Nov 07 13:16:58 2015 +0100 @@ -63,7 +63,7 @@ self.options.repo_update_list.split(',')) \ if self.options.repo_update_list else None - if repo_update_list: + if repo_update_list is not None: repo_list = list(Repository.query()\ .filter(Repository.repo_name.in_(repo_update_list))) else:
--- a/kallithea/lib/vcs/backends/git/changeset.py Sat Nov 07 13:16:57 2015 +0100 +++ b/kallithea/lib/vcs/backends/git/changeset.py Sat Nov 07 13:16:58 2015 +0100 @@ -287,7 +287,7 @@ cs_id = safe_str(self.id) f_path = safe_str(path) - if limit: + if limit is not None: cmd = ['log', '-n', str(safe_int(limit, 0)), '--pretty=format:%H', '-s', cs_id, '--', f_path]
--- a/kallithea/lib/vcs/backends/hg/changeset.py Sat Nov 07 13:16:57 2015 +0100 +++ b/kallithea/lib/vcs/backends/hg/changeset.py Sat Nov 07 13:16:58 2015 +0100 @@ -256,7 +256,7 @@ for cs in reversed([x for x in fctx.filelog()]): cnt += 1 hist.append(hex(fctx.filectx(cs).node())) - if limit and cnt == limit: + if limit is not None and cnt == limit: break return [self.repository.get_changeset(node) for node in hist]
--- a/kallithea/model/repo.py Sat Nov 07 13:16:57 2015 +0100 +++ b/kallithea/model/repo.py Sat Nov 07 13:16:58 2015 +0100 @@ -175,7 +175,7 @@ @classmethod def update_repoinfo(cls, repositories=None): - if not repositories: + if repositories is None: repositories = Repository.getAll() for repo in repositories: repo.update_changeset_cache()