changeset 990:7a1df0130533 beta

moved tooltip function from the for loop and from templates to helpers
author Marcin Kuzminski <marcin@python-works.com>
date Tue, 01 Feb 2011 15:19:42 +0100
parents 801cdb3e0969
children b232a36cc51f e80b2cbbd4ba
files rhodecode/lib/helpers.py rhodecode/templates/changelog/changelog.html
diffstat 2 files changed, 14 insertions(+), 17 deletions(-) [+]
line wrap: on
line diff
--- a/rhodecode/lib/helpers.py	Tue Feb 01 02:18:05 2011 +0100
+++ b/rhodecode/lib/helpers.py	Tue Feb 01 15:19:42 2011 +0100
@@ -593,3 +593,13 @@
             u_str = unicode(str(str).encode('string_escape'))
 
     return u_str
+
+def changed_tooltip(nodes):
+    if nodes:
+        pref = ': <br/> '
+        suf = ''
+        if len(nodes) > 30:
+            suf = '<br/>' + _(' and %s more') % (len(nodes) - 30)
+        return literal(pref + '<br/> '.join([x.path for x in nodes[:30]]) + suf)
+    else:
+        return ': ' + _('No Files')
--- a/rhodecode/templates/changelog/changelog.html	Tue Feb 01 02:18:05 2011 +0100
+++ b/rhodecode/templates/changelog/changelog.html	Tue Feb 01 15:19:42 2011 +0100
@@ -61,23 +61,10 @@
 							<div class="message">${h.link_to(h.wrap_paragraphs(cs.message),h.url('changeset_home',repo_name=c.repo_name,revision=cs.raw_id))}</div>
 						</div>	
 						<div class="right">
-									<div class="changes">
-									
-									   <%
-									       def changed_tooltip(cs):
-                                               if cs:
-                                                   pref = ': '
-                                                   suf = '' 
-                                                   if len(cs) > 30:
-                                                      suf='<br/>'+_(' and %s more') % (len(cs) - 30)
-                                                   return pref+'<br/> '.join([x.path for x in cs[:30]]) + suf
-                                               else:
-                                                   return ': '+_('No Files')
-                                       %>
-									
-										<span class="removed tooltip" title="${_('removed')}${h.literal(changed_tooltip(cs.removed))}">${len(cs.removed)}</span>
-										<span class="changed tooltip" title="${_('changed')}${h.literal(changed_tooltip(cs.changed))}">${len(cs.changed)}</span>
-										<span class="added tooltip" title="${_('added')}${h.literal(changed_tooltip(cs.added))}">${len(cs.added)}</span>
+									<div class="changes">									
+										<span class="removed tooltip" title="<b>${_('removed')}</b>${h.changed_tooltip(cs.removed)}">${len(cs.removed)}</span>
+										<span class="changed tooltip" title="<b>${_('changed')}</b>${h.changed_tooltip(cs.changed)}">${len(cs.changed)}</span>
+										<span class="added tooltip" title="<b>${_('added')}</b>${h.changed_tooltip(cs.added)}">${len(cs.added)}</span>
 									</div>					
 										%if len(cs.parents)>1:
 										<div class="merge">