changeset 1595:7cd8fd4d1e38 beta

#286 raise HttpForbidden if username lookup failed instead of internal server error
author Marcin Kuzminski <marcin@python-works.com>
date Mon, 24 Oct 2011 23:07:06 +0200
parents 9dae92a65e40
children 089ef495e9dd
files rhodecode/lib/middleware/simplegit.py rhodecode/lib/middleware/simplehg.py
diffstat 2 files changed, 4 insertions(+), 0 deletions(-) [+]
line wrap: on
line diff
--- a/rhodecode/lib/middleware/simplegit.py	Mon Oct 24 22:40:43 2011 +0200
+++ b/rhodecode/lib/middleware/simplegit.py	Mon Oct 24 23:07:06 2011 +0200
@@ -167,6 +167,8 @@
                     username = REMOTE_USER(environ)
                     try:
                         user = self.__get_user(username)
+                        if user is None:
+                            return HTTPForbidden()(environ, start_response)                        
                         username = user.username
                     except:
                         log.error(traceback.format_exc())
--- a/rhodecode/lib/middleware/simplehg.py	Mon Oct 24 22:40:43 2011 +0200
+++ b/rhodecode/lib/middleware/simplehg.py	Mon Oct 24 23:07:06 2011 +0200
@@ -133,6 +133,8 @@
                     username = REMOTE_USER(environ)
                     try:
                         user = self.__get_user(username)
+                        if user is None:
+                            return HTTPForbidden()(environ, start_response)
                         username = user.username
                     except:
                         log.error(traceback.format_exc())