Mercurial > kallithea
changeset 4884:87f5ca5cbd7e
compare: don't use sql 'in' on empty sets
| author | Mads Kiilerich <madski@unity3d.com> |
|---|---|
| date | Fri, 06 Mar 2015 16:21:24 +0100 |
| parents | 8b08599d4b08 |
| children | dea513b7004b |
| files | kallithea/model/db.py |
| diffstat | 1 files changed, 2 insertions(+), 0 deletions(-) [+] |
line wrap: on
line diff
--- a/kallithea/model/db.py Fri Mar 06 16:21:24 2015 +0100 +++ b/kallithea/model/db.py Fri Mar 06 16:21:24 2015 +0100 @@ -1359,6 +1359,8 @@ cmts = ChangesetComment.query()\ .filter(ChangesetComment.repo == self) if revisions is not None: + if not revisions: + return [] # don't use sql 'in' on empty set cmts = cmts.filter(ChangesetComment.revision.in_(revisions)) grouped = collections.defaultdict(list) for cmt in cmts.all():