Mercurial > kallithea
changeset 8304:9e4f0baa18e7
login: clarify comments
author | Mads Kiilerich <mads@kiilerich.com> |
---|---|
date | Mon, 23 Mar 2020 14:29:31 +0100 |
parents | 2cb54d157d62 |
children | 6056c0e8244f |
files | kallithea/controllers/login.py |
diffstat | 1 files changed, 2 insertions(+), 1 deletions(-) [+] |
line wrap: on
line diff
--- a/kallithea/controllers/login.py Mon Mar 23 14:32:06 2020 +0100 +++ b/kallithea/controllers/login.py Mon Mar 23 14:29:31 2020 +0100 @@ -79,8 +79,8 @@ # import Login Form validator class login_form = LoginForm()() try: + # login_form will check username/password using ValidAuth and report failure to the user c.form_result = login_form.to_python(dict(request.POST)) - # form checks for username/password, now we're authenticated username = c.form_result['username'] user = User.get_by_username_or_email(username) assert user is not None # the same user get just passed in the form validation @@ -102,6 +102,7 @@ # Exception itself h.flash(e, 'error') else: + # login_form already validated the password - now set the session cookie accordingly auth_user = log_in_user(user, c.form_result['remember'], is_external_auth=False, ip_addr=request.ip_addr) if auth_user: raise HTTPFound(location=c.came_from)