changeset 4058:a2218bdbf45d

pull requests: make title optional - generate one automatically
author Mads Kiilerich <madski@unity3d.com>
date Wed, 12 Jun 2013 12:23:20 +0200
parents 6eaee7e2829e
children 31ca78c45705
files rhodecode/controllers/pullrequests.py rhodecode/model/forms.py
diffstat 2 files changed, 3 insertions(+), 1 deletions(-) [+]
line wrap: on
line diff
--- a/rhodecode/controllers/pullrequests.py	Thu Jun 27 23:54:22 2013 +0200
+++ b/rhodecode/controllers/pullrequests.py	Wed Jun 12 12:23:20 2013 +0200
@@ -335,6 +335,8 @@
         reviewers = _form['review_members']
 
         title = _form['pullrequest_title']
+        if not title:
+            title = '%s#%s to %s' % (org_repo, org_ref.split(':', 2)[1], other_repo)
         description = _form['pullrequest_desc']
         try:
             pull_request = PullRequestModel().create(
--- a/rhodecode/model/forms.py	Thu Jun 27 23:54:22 2013 +0200
+++ b/rhodecode/model/forms.py	Wed Jun 12 12:23:20 2013 +0200
@@ -415,7 +415,7 @@
                         v.UniqueList(not_empty=True))
         review_members = v.UniqueList(not_empty=True)
 
-        pullrequest_title = v.UnicodeString(strip=True, required=True, min=3)
+        pullrequest_title = v.UnicodeString(strip=True, required=True)
         pullrequest_desc = v.UnicodeString(strip=True, required=False)
 
         ancestor_rev = v.UnicodeString(strip=True, required=True)