changeset 421:cbfb853a0a4c

fixed bug when author had " in name, thus breaking the javascript data format small fix to css for commit messages, and fixed a bug when message had some special chars that caused unicodeDecode error
author Marcin Kuzminski <marcin@python-works.com>
date Mon, 23 Aug 2010 21:39:17 +0200
parents a6000c18a8db
children fc3613065baf
files pylons_app/controllers/summary.py pylons_app/public/css/style.css pylons_app/templates/changelog/changelog.html
diffstat 3 files changed, 7 insertions(+), 4 deletions(-) [+]
line wrap: on
line diff
--- a/pylons_app/controllers/summary.py	Sat Aug 21 18:33:13 2010 +0200
+++ b/pylons_app/controllers/summary.py	Mon Aug 23 21:39:17 2010 +0200
@@ -84,6 +84,7 @@
         
         def author_key_cleaner(k):
             k = person(k)
+            k = k.replace('"', "'") #for js data compatibilty
             return k
                 
         for cs in repo:
--- a/pylons_app/public/css/style.css	Sat Aug 21 18:33:13 2010 +0200
+++ b/pylons_app/public/css/style.css	Mon Aug 23 21:39:17 2010 +0200
@@ -1039,8 +1039,8 @@
 
 #content div.box div.message
 {
-	margin: 0 0 10px 0;
-    padding: 0;
+	margin: 0 0 0px 0;
+    padding: 0 0 10px 0;
 	clear: both;
 	overflow: hidden;
 }
--- a/pylons_app/templates/changelog/changelog.html	Sat Aug 21 18:33:13 2010 +0200
+++ b/pylons_app/templates/changelog/changelog.html	Mon Aug 23 21:39:17 2010 +0200
@@ -1,3 +1,5 @@
+## -*- coding: utf-8 -*-
+
 <%inherit file="/base/base.html"/>
 
 <%def name="title()">
@@ -59,7 +61,7 @@
 								<span><a href="mailto:${h.email_or_none(cs.author)}">${h.email_or_none(cs.author)}</a></span><br/>
 							</div>
 							<div class="message">
-								${h.link_to(h.wrap_paragraphs(cs.message),
+								${h.link_to(h.wrap_paragraphs(cs.message.decode('utf-8','replace')),
 								h.url('changeset_home',repo_name=c.repo_name,revision=cs.raw_id))}
 							</div>
 						</div>	
@@ -76,7 +78,7 @@
 										%endif						
 									%for p_cs in reversed(cs.parents):
 										<div class="parent">${_('Parent')} ${p_cs.revision}: ${h.link_to(p_cs.raw_id,
-											h.url('changeset_home',repo_name=c.repo_name,revision=p_cs.raw_id),title=p_cs.message)}
+											h.url('changeset_home',repo_name=c.repo_name,revision=p_cs.raw_id),title=p_cs.message.decode('utf-8','replace'))}
 										</div>
 									%endfor								
 						</div>