Mercurial > kallithea

changeset 8926:cc70797e70e1 stable

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
usergroup: fix adding permission Clicking "Add new" on /_admin/user_groups/1/edit/perms would flicker the input fields, and then show "User group permissions updated". That turns out to be because HTML button tags default to 'submit' inside forms, and in this place (but not for user or repo group permissions) we didn't specify the button type as 'button'. There might be other similar problems.
author Mads Kiilerich <mads@kiilerich.com>
date Mon, 27 Jun 2022 20:30:00 +0200
parents ee1da602b590
children 5572eb8d4feb
files kallithea/templates/admin/user_groups/user_group_edit_perms.html
diffstat 1 files changed, 1 insertions(+), 1 deletions(-) [+]
line wrap: on
line diff
--- a/kallithea/templates/admin/user_groups/user_group_edit_perms.html	Wed Sep 01 22:08:45 2021 +0200
+++ b/kallithea/templates/admin/user_groups/user_group_edit_perms.html	Mon Jun 27 20:30:00 2022 +0200
@@ -77,7 +77,7 @@
                 <tr class="new_members last_new_member" id="add_perm_input"><td colspan="6"></td></tr>
                 <tr>
                     <td colspan="6">
-                        <button id="add_perm" class="btn btn-link btn-xs">
+                        <button type="button" id="add_perm" class="btn btn-link btn-xs">
                             <i class="icon-plus"></i>${_('Add new')}
                         </button>
                     </td>