Mercurial > kallithea
changeset 7161:d9fc7312177e
HTML email templates: don't use link color for PR descriptions
The link color should only be used for actual hyperlinks.
Using it for anything else is very confusing for users.
For pullrequest mails, the usage of the link color for the PR description
may have been done to separate the description more clearly from the title
word 'Description' above it.
Instead, use a table with grey background similar to how comments are
displayed. This meets the objective of not abusing link colors as well as
clearly separating the description from the rest of the mail.
| author | Thomas De Schampheleire <thomas.de_schampheleire@nokia.com> |
|---|---|
| date | Sat, 03 Feb 2018 22:29:41 +0100 |
| parents | 2b2e37660e95 |
| children | 3a3d9c8432ed |
| files | kallithea/templates/email_templates/pull_request.html kallithea/tests/models/test_dump_html_mails.ref.html |
| diffstat | 2 files changed, 45 insertions(+), 3 deletions(-) [+] |
line wrap: on
line diff
--- a/kallithea/templates/email_templates/pull_request.html Tue Feb 13 11:09:14 2018 +0100 +++ b/kallithea/templates/email_templates/pull_request.html Sat Feb 03 22:29:41 2018 +0100 @@ -40,7 +40,21 @@ <tr><td height="10px" style="height:10px"></td></tr> <tr> <td> - <div style="${comment_style};color:${color_link}">${body}</div> + <table cellpadding="0" cellspacing="0" width="100%" border="0" bgcolor="${color_background_grey}" style="border:1px solid ${color_border};border-radius:4px"> + <tr> + <td height="10px" style="height:10px" colspan="3"></td> + </tr> + <tr> + <td width="20px" style="width:20px"></td> + <td> + <div style="${comment_style}">${body}</div> + </td> + <td width="20px" style="width:20px"></td> + </tr> + <tr> + <td height="10px" style="height:10px" colspan="3"></td> + </tr> + </table> </td> </tr> <tr><td height="15px" style="height:15px"></td></tr>
--- a/kallithea/tests/models/test_dump_html_mails.ref.html Tue Feb 13 11:09:14 2018 +0100 +++ b/kallithea/tests/models/test_dump_html_mails.ref.html Sat Feb 03 22:29:41 2018 +0100 @@ -987,7 +987,21 @@ <tr><td height="10px" style="height:10px"></td></tr> <tr> <td> - <div style="font-family:Lucida Console,Consolas,Monaco,Inconsolata,Liberation Mono,monospace;white-space:pre-wrap;color:#395fa0"><div class="formatted-fixed">This PR is 'awesome' because it does <stuff><br/> - please approve indented!</div></div> + <table cellpadding="0" cellspacing="0" width="100%" border="0" bgcolor="#f9f9f9" style="border:1px solid #ddd;border-radius:4px"> + <tr> + <td height="10px" style="height:10px" colspan="3"></td> + </tr> + <tr> + <td width="20px" style="width:20px"></td> + <td> + <div style="font-family:Lucida Console,Consolas,Monaco,Inconsolata,Liberation Mono,monospace;white-space:pre-wrap"><div class="formatted-fixed">This PR is 'awesome' because it does <stuff><br/> - please approve indented!</div></div> + </td> + <td width="20px" style="width:20px"></td> + </tr> + <tr> + <td height="10px" style="height:10px" colspan="3"></td> + </tr> + </table> </td> </tr> <tr><td height="15px" style="height:15px"></td></tr> @@ -1162,7 +1176,21 @@ <tr><td height="10px" style="height:10px"></td></tr> <tr> <td> - <div style="font-family:Lucida Console,Consolas,Monaco,Inconsolata,Liberation Mono,monospace;white-space:pre-wrap;color:#395fa0"><div class="formatted-fixed">This PR is 'awesome' because it does <stuff><br/> - please approve indented!</div></div> + <table cellpadding="0" cellspacing="0" width="100%" border="0" bgcolor="#f9f9f9" style="border:1px solid #ddd;border-radius:4px"> + <tr> + <td height="10px" style="height:10px" colspan="3"></td> + </tr> + <tr> + <td width="20px" style="width:20px"></td> + <td> + <div style="font-family:Lucida Console,Consolas,Monaco,Inconsolata,Liberation Mono,monospace;white-space:pre-wrap"><div class="formatted-fixed">This PR is 'awesome' because it does <stuff><br/> - please approve indented!</div></div> + </td> + <td width="20px" style="width:20px"></td> + </tr> + <tr> + <td height="10px" style="height:10px" colspan="3"></td> + </tr> + </table> </td> </tr> <tr><td height="15px" style="height:15px"></td></tr>