Mercurial > kallithea
changeset 5201:ea284e51ec2e
pullrequest: warn for duplication of reviewer handling with base.js
author | Thomas De Schampheleire <thomas.de_schampheleire@alcatel-lucent.com> |
---|---|
date | Fri, 19 Jun 2015 15:40:27 +0200 |
parents | a7ac467edbf5 |
children | 90e982b6bca8 |
files | kallithea/public/js/base.js kallithea/templates/pullrequests/pullrequest_show.html |
diffstat | 2 files changed, 6 insertions(+), 0 deletions(-) [+] |
line wrap: on
line diff
--- a/kallithea/public/js/base.js Fri Jun 19 18:06:39 2015 +0200 +++ b/kallithea/public/js/base.js Fri Jun 19 15:40:27 2015 +0200 @@ -1473,6 +1473,9 @@ var gravatarelm = '<img alt="gravatar" style="width: {0}px; height: {0}px" src="{1}"/>'.format(gravatar_size, gravatar_link); if (!gravatar_link) gravatarelm = '<i class="icon-user" style="font-size: {0}px;"></i>'.format(gravatar_size); + // WARNING: the HTML below is duplicate with + // kallithea/templates/pullrequests/pullrequest_show.html + // If you change something here it should be reflected in the template too. var element = ( ' <li id="reviewer_{2}">\n'+ ' <div class="reviewers_member">\n'+
--- a/kallithea/templates/pullrequests/pullrequest_show.html Fri Jun 19 18:06:39 2015 +0200 +++ b/kallithea/templates/pullrequests/pullrequest_show.html Fri Jun 19 15:40:27 2015 +0200 @@ -212,6 +212,9 @@ <div> <ul id="review_members" class="group_members"> %for member,status in c.pull_request_reviewers: + ## WARNING: the HTML below is duplicate with + ## kallithea/public/js/base.js + ## If you change something here it should be reflected in the template too. <li id="reviewer_${member.user_id}"> <div class="reviewers_member"> <div class="reviewer_status tooltip" title="${h.tooltip(h.changeset_status_lbl(status.status if status else 'not_reviewed'))}">