changeset 7141:f200ce5efce6

tests: enable disabled Git branch tests, with comments that the current results seem wrong
author Mads Kiilerich <mads@kiilerich.com>
date Sun, 28 Jan 2018 00:16:18 +0100
parents 3020943319f7
children 3dbb625d5f9c
files kallithea/tests/vcs/test_git.py
diffstat 1 files changed, 7 insertions(+), 9 deletions(-) [+]
line wrap: on
line diff
--- a/kallithea/tests/vcs/test_git.py	Sun Feb 11 21:33:37 2018 +0100
+++ b/kallithea/tests/vcs/test_git.py	Sun Jan 28 00:16:18 2018 +0100
@@ -304,27 +304,25 @@
                              .get_node('index.rst')
 
     def test_branch_and_tags(self):
-        """
+        # Those tests seem to show wrong results:
+        # in Git, only heads have a branch - most changesets don't
         rev0 = self.repo.revisions[0]
         chset0 = self.repo.get_changeset(rev0)
-        assert chset0.branch == 'master'
+        assert chset0.branch is None # should be 'master'?
         assert chset0.tags == []
 
         rev10 = self.repo.revisions[10]
         chset10 = self.repo.get_changeset(rev10)
-        assert chset10.branch == 'master'
+        assert chset10.branch is None # should be 'master'?
         assert chset10.tags == []
 
         rev44 = self.repo.revisions[44]
         chset44 = self.repo.get_changeset(rev44)
-        assert chset44.branch == 'web-branch'
+        assert chset44.branch is None # should be 'web-branch'?
 
         tip = self.repo.get_changeset('tip')
-        assert 'tip' in tip.tags
-        """
-        # Those tests would fail - branches are now going
-        # to be changed at main API in order to support git backend
-        pass
+        assert 'tip' not in tip.tags # it should be?
+        assert not tip.tags # how it is!
 
     def _test_slices(self, limit, offset):
         count = self.repo.count()