Mercurial > kallithea
changeset 6228:f35ddb654668
repos: inline RepoModel.update_repoinfo
It had only two invocations, each triggering separate code paths, all
to do a simple loop.
| author | Søren Løvborg <sorenl@unity3d.com> |
|---|---|
| date | Thu, 15 Sep 2016 13:57:47 +0200 |
| parents | 555c8d26988f |
| children | 4136526cce20 |
| files | kallithea/lib/db_manage.py kallithea/lib/paster_commands/update_repoinfo.py kallithea/model/repo.py |
| diffstat | 3 files changed, 4 insertions(+), 9 deletions(-) [+] |
line wrap: on
line diff
--- a/kallithea/lib/db_manage.py Tue Sep 13 18:40:49 2016 +0200 +++ b/kallithea/lib/db_manage.py Thu Sep 15 13:57:47 2016 +0200 @@ -362,7 +362,8 @@ return fixed def update_repo_info(self): - RepoModel.update_repoinfo() + for repo in Repository.query(): + repo.update_changeset_cache() def config_prompt(self, test_repo_path='', retries=3): _path = self.cli_args.get('repos_location')
--- a/kallithea/lib/paster_commands/update_repoinfo.py Tue Sep 13 18:40:49 2016 +0200 +++ b/kallithea/lib/paster_commands/update_repoinfo.py Thu Sep 15 13:57:47 2016 +0200 @@ -60,7 +60,8 @@ for n in self.options.repo_update_list.split(',')] repo_list = list(Repository.query() .filter(Repository.repo_name.in_(repo_names))) - RepoModel.update_repoinfo(repositories=repo_list) + for repo in repo_list: + repo.update_changeset_cache() Session().commit() if self.options.invalidate_cache:
--- a/kallithea/model/repo.py Tue Sep 13 18:40:49 2016 +0200 +++ b/kallithea/model/repo.py Thu Sep 15 13:57:47 2016 +0200 @@ -176,13 +176,6 @@ kwargs.update(dict(_=_, h=h, c=c)) return tmpl.render(*args, **kwargs) - @classmethod - def update_repoinfo(cls, repositories=None): - if repositories is None: - repositories = Repository.query() - for repo in repositories: - repo.update_changeset_cache() - def get_repos_as_dict(self, repos_list=None, admin=False, perm_check=True, super_user_actions=False, short_name=False): _render = self._render_datatable