Mercurial > kallithea
changeset 8085:f9c55f700ad9 stable
logging: drop fileConfig initialization in make_app - backout 0d4dd9380a45
0d4dd9380a45 was a bit harmful, as it might overwrite existing good logging
configuration.
0d4dd9380a45 no longer seems relevant: Testing shows that logging for `gearbox
serve` *is* activated anyway. gearbox/commands/serve.py will invoke
"setup_logging" right before "loadapp".
We must and can assume that logging has been initialized before make_app.
Reported and based on analysis by Wolfgang Scherer.
| author | Mads Kiilerich <mads@kiilerich.com> |
|---|---|
| date | Mon, 30 Dec 2019 00:03:19 +0100 |
| parents | 1ba3aeefe033 |
| children | 488b52cad890 |
| files | kallithea/config/middleware.py |
| diffstat | 1 files changed, 0 insertions(+), 3 deletions(-) [+] |
line wrap: on
line diff
--- a/kallithea/config/middleware.py Sun Dec 29 15:35:06 2019 +0100 +++ b/kallithea/config/middleware.py Mon Dec 30 00:03:19 2019 +0100 @@ -13,8 +13,6 @@ # along with this program. If not, see <http://www.gnu.org/licenses/>. """WSGI middleware initialization for the Kallithea application.""" -import logging.config - from kallithea.config.app_cfg import base_config from kallithea.config.environment import load_environment @@ -49,5 +47,4 @@ ``app_conf`` contains all the application-specific settings (those defined under ``[app:main]``. """ - logging.config.fileConfig(global_conf['__file__']) return make_app_without_logging(global_conf, full_stack=full_stack, **app_conf)