changeset 6445:fb565a8b4b4f

mails: make title in header boxes slightly bolder In my opinion, the top headers in the new mail styling seemed a bit "thin" compared to the other headers.
author Mads Kiilerich <mads@kiilerich.com>
date Sun, 22 Jan 2017 01:16:51 +0100
parents e4e13a7cc438
children 347f38529080
files kallithea/model/notification.py kallithea/templates/email_templates/comment.html kallithea/templates/email_templates/header.html kallithea/tests/models/test_dump_html_mails.ref.html
diffstat 4 files changed, 21 insertions(+), 20 deletions(-) [+]
line wrap: on
line diff
--- a/kallithea/model/notification.py	Sun Jan 22 01:16:51 2017 +0100
+++ b/kallithea/model/notification.py	Sun Jan 22 01:16:51 2017 +0100
@@ -339,6 +339,7 @@
             _kwargs.update({
                 "default_style": "%(sans_style)s;font-weight:200;font-size:14px;line-height:17px;color:%(color_text)s" % _kwargs,
                 "comment_style": "%(monospace_style)s;white-space:pre-wrap" % _kwargs,
+                "emph_style": "font-weight:600;color:%(color_emph)s" % _kwargs,
                 })
 
         log.debug('rendering tmpl %s with kwargs %s', base, _kwargs)
--- a/kallithea/templates/email_templates/comment.html	Sun Jan 22 01:16:51 2017 +0100
+++ b/kallithea/templates/email_templates/comment.html	Sun Jan 22 01:16:51 2017 +0100
@@ -8,7 +8,7 @@
     <tr>
         <td width="20px"></td>
         <td>
-            <div style="font-weight:600;color:${color_emph}">${author}</div>
+            <div style="${emph_style}">${author}</div>
         </td>
         <td width="20px"></td>
     </tr>
--- a/kallithea/templates/email_templates/header.html	Sun Jan 22 01:16:51 2017 +0100
+++ b/kallithea/templates/email_templates/header.html	Sun Jan 22 01:16:51 2017 +0100
@@ -10,10 +10,10 @@
         <td width="30px"></td>
         <td style="${sans_style};font-size:19px;line-height:24px">
         %if link is not None:
-            <a style="text-decoration:none;color:${color_emph}" href="${link}"
+            <a style="text-decoration:none;${emph_style}" href="${link}"
                target="_blank">${title}</a>
         %else:
-            <span style="color:${color_emph}">${title}</span>
+            <span style="${emph_style}">${title}</span>
         %endif
         </td>
         <td width="30px"></td>
--- a/kallithea/tests/models/test_dump_html_mails.ref.html	Sun Jan 22 01:16:51 2017 +0100
+++ b/kallithea/tests/models/test_dump_html_mails.ref.html	Sun Jan 22 01:16:51 2017 +0100
@@ -54,7 +54,7 @@
     <tr>
         <td width="30px"></td>
         <td style="font-family:Helvetica,Arial,sans-serif;font-size:19px;line-height:24px">
-            <a style="text-decoration:none;color:#395fa0" href="http://comment.org"
+            <a style="text-decoration:none;font-weight:600;color:#395fa0" href="http://comment.org"
                target="_blank">Comment on Changeset &#34;This changeset did something clever which is hard to explain&#34;</a>
         </td>
         <td width="30px"></td>
@@ -211,7 +211,7 @@
     <tr>
         <td width="30px"></td>
         <td style="font-family:Helvetica,Arial,sans-serif;font-size:19px;line-height:24px">
-            <a style="text-decoration:none;color:#395fa0" href="http://comment.org"
+            <a style="text-decoration:none;font-weight:600;color:#395fa0" href="http://comment.org"
                target="_blank">Mention in Comment on Changeset &#34;This changeset did something clever which is hard to explain&#34;</a>
         </td>
         <td width="30px"></td>
@@ -370,7 +370,7 @@
     <tr>
         <td width="30px"></td>
         <td style="font-family:Helvetica,Arial,sans-serif;font-size:19px;line-height:24px">
-            <a style="text-decoration:none;color:#395fa0" href="http://comment.org"
+            <a style="text-decoration:none;font-weight:600;color:#395fa0" href="http://comment.org"
                target="_blank">Comment on Changeset &#34;This changeset did something clever which is hard to explain&#34;</a>
         </td>
         <td width="30px"></td>
@@ -545,7 +545,7 @@
     <tr>
         <td width="30px"></td>
         <td style="font-family:Helvetica,Arial,sans-serif;font-size:19px;line-height:24px">
-            <a style="text-decoration:none;color:#395fa0" href="http://comment.org"
+            <a style="text-decoration:none;font-weight:600;color:#395fa0" href="http://comment.org"
                target="_blank">Mention in Comment on Changeset &#34;This changeset did something clever which is hard to explain&#34;</a>
         </td>
         <td width="30px"></td>
@@ -702,7 +702,7 @@
     <tr>
         <td width="30px"></td>
         <td style="font-family:Helvetica,Arial,sans-serif;font-size:19px;line-height:24px">
-            <span style="color:#395fa0">Message</span>
+            <span style="font-weight:600;color:#395fa0">Message</span>
         </td>
         <td width="30px"></td>
     </tr>
@@ -785,7 +785,7 @@
     <tr>
         <td width="30px"></td>
         <td style="font-family:Helvetica,Arial,sans-serif;font-size:19px;line-height:24px">
-            <a style="text-decoration:none;color:#395fa0" href="http://newbie.org"
+            <a style="text-decoration:none;font-weight:600;color:#395fa0" href="http://newbie.org"
                target="_blank">New User Registration</a>
         </td>
         <td width="30px"></td>
@@ -925,7 +925,7 @@
     <tr>
         <td width="30px"></td>
         <td style="font-family:Helvetica,Arial,sans-serif;font-size:19px;line-height:24px">
-            <a style="text-decoration:none;color:#395fa0" href="http://pr.org/7"
+            <a style="text-decoration:none;font-weight:600;color:#395fa0" href="http://pr.org/7"
                target="_blank">Added as Reviewer of Pull Request #7 &#34;The Title&#34; by Requesting User (root)</a>
         </td>
         <td width="30px"></td>
@@ -1098,7 +1098,7 @@
     <tr>
         <td width="30px"></td>
         <td style="font-family:Helvetica,Arial,sans-serif;font-size:19px;line-height:24px">
-            <a style="text-decoration:none;color:#395fa0" href="http://pr.org/7"
+            <a style="text-decoration:none;font-weight:600;color:#395fa0" href="http://pr.org/7"
                target="_blank">Mention on Pull Request #7 &#34;The Title&#34; by Requesting User (root)</a>
         </td>
         <td width="30px"></td>
@@ -1266,7 +1266,7 @@
     <tr>
         <td width="30px"></td>
         <td style="font-family:Helvetica,Arial,sans-serif;font-size:19px;line-height:24px">
-            <a style="text-decoration:none;color:#395fa0" href="http://pr.org/comment"
+            <a style="text-decoration:none;font-weight:600;color:#395fa0" href="http://pr.org/comment"
                target="_blank">Comment on Pull Request #7 &#34;The Title&#34;</a>
         </td>
         <td width="30px"></td>
@@ -1429,7 +1429,7 @@
     <tr>
         <td width="30px"></td>
         <td style="font-family:Helvetica,Arial,sans-serif;font-size:19px;line-height:24px">
-            <a style="text-decoration:none;color:#395fa0" href="http://pr.org/comment"
+            <a style="text-decoration:none;font-weight:600;color:#395fa0" href="http://pr.org/comment"
                target="_blank">Mention in Comment on Pull Request #7 &#34;The Title&#34;</a>
         </td>
         <td width="30px"></td>
@@ -1594,7 +1594,7 @@
     <tr>
         <td width="30px"></td>
         <td style="font-family:Helvetica,Arial,sans-serif;font-size:19px;line-height:24px">
-            <a style="text-decoration:none;color:#395fa0" href="http://pr.org/comment"
+            <a style="text-decoration:none;font-weight:600;color:#395fa0" href="http://pr.org/comment"
                target="_blank">Comment on Pull Request #7 &#34;The Title&#34;</a>
         </td>
         <td width="30px"></td>
@@ -1775,7 +1775,7 @@
     <tr>
         <td width="30px"></td>
         <td style="font-family:Helvetica,Arial,sans-serif;font-size:19px;line-height:24px">
-            <a style="text-decoration:none;color:#395fa0" href="http://pr.org/comment"
+            <a style="text-decoration:none;font-weight:600;color:#395fa0" href="http://pr.org/comment"
                target="_blank">Mention in Comment on Pull Request #7 &#34;The Title&#34;</a>
         </td>
         <td width="30px"></td>
@@ -1956,7 +1956,7 @@
     <tr>
         <td width="30px"></td>
         <td style="font-family:Helvetica,Arial,sans-serif;font-size:19px;line-height:24px">
-            <a style="text-decoration:none;color:#395fa0" href="http://pr.org/comment"
+            <a style="text-decoration:none;font-weight:600;color:#395fa0" href="http://pr.org/comment"
                target="_blank">Pull Request #7 &#34;The Title&#34; Closed</a>
         </td>
         <td width="30px"></td>
@@ -2136,7 +2136,7 @@
     <tr>
         <td width="30px"></td>
         <td style="font-family:Helvetica,Arial,sans-serif;font-size:19px;line-height:24px">
-            <a style="text-decoration:none;color:#395fa0" href="http://pr.org/comment"
+            <a style="text-decoration:none;font-weight:600;color:#395fa0" href="http://pr.org/comment"
                target="_blank">Mention in Comment on Pull Request #7 &#34;The Title&#34;</a>
         </td>
         <td width="30px"></td>
@@ -2318,7 +2318,7 @@
     <tr>
         <td width="30px"></td>
         <td style="font-family:Helvetica,Arial,sans-serif;font-size:19px;line-height:24px">
-            <a style="text-decoration:none;color:#395fa0" href="http://pr.org/comment"
+            <a style="text-decoration:none;font-weight:600;color:#395fa0" href="http://pr.org/comment"
                target="_blank">Pull Request #7 &#34;The Title&#34; Closed</a>
         </td>
         <td width="30px"></td>
@@ -2504,7 +2504,7 @@
     <tr>
         <td width="30px"></td>
         <td style="font-family:Helvetica,Arial,sans-serif;font-size:19px;line-height:24px">
-            <a style="text-decoration:none;color:#395fa0" href="http://pr.org/comment"
+            <a style="text-decoration:none;font-weight:600;color:#395fa0" href="http://pr.org/comment"
                target="_blank">Mention in Comment on Pull Request #7 &#34;The Title&#34;</a>
         </td>
         <td width="30px"></td>
@@ -2683,7 +2683,7 @@
     <tr>
         <td width="30px"></td>
         <td style="font-family:Helvetica,Arial,sans-serif;font-size:19px;line-height:24px">
-            <span style="color:#395fa0">Password Reset Request</span>
+            <span style="font-weight:600;color:#395fa0">Password Reset Request</span>
         </td>
         <td width="30px"></td>
     </tr>