gemma: pkg/imports/wa.go annotate

annotate pkg/imports/wa.go @ 4844:58642179e896

Fix possibly invalid geometry output from transformation Transformation to the final SRS (EPSG:4326) might as well generate invalid geometries. Thus, fix the geometries afterwards. The inner ST_MakeValid is still needed to get correct intersection results, but the intermediate transformation to some UTM projection without any further processing is useless.

author	Tom Gottfried <tom@intevation.de>
date	Wed, 13 Nov 2019 13:51:10 +0100
parents	5062ccb2381d
children	046a07a33b19

rev	line source
1785 614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	1 // This is Free Software under GNU Affero General Public License v >= 3.0
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	2 // without warranty, see README.md and license for details.
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	3 //
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	4 // SPDX-License-Identifier: AGPL-3.0-or-later
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	5 // License-Filename: LICENSES/AGPL-3.0.txt
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	6 //
2649 9b6a02923bb4 Allow sys_admin to import waterway axis and area without clipping Tom Gottfried <tom@intevation.de> parents: 2622 diff changeset	7 // Copyright (C) 2018, 2019 by via donau
1785 614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	8 // – Österreichische Wasserstraßen-Gesellschaft mbH
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	9 // Software engineering by Intevation GmbH
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	10 //
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	11 // Author(s):
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	12 // * Sascha L. Teichmann <sascha.teichmann@intevation.de>
2649 9b6a02923bb4 Allow sys_admin to import waterway axis and area without clipping Tom Gottfried <tom@intevation.de> parents: 2622 diff changeset	13 // * Tom Gottfried <tom.gottfried@intevation.de>
1785 614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	14
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	15 package imports
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	16
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	17 import (
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	18 "context"
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	19 "database/sql"
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	20 "encoding/json"
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	21 "errors"
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	22 "fmt"
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	23 "io"
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	24 "strconv"
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	25 "time"
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	26
4062 6c760abcff0e Move handling of PostgreSQL errors to own package Tom Gottfried <tom@intevation.de> parents: 4058 diff changeset	27 "gemma.intevation.de/gemma/pkg/pgxutils"
1785 614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	28 "gemma.intevation.de/gemma/pkg/wfs"
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	29 )
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	30
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	31 // WaterwayArea is an import job to import
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	32 // the waterway area in form of polygon geometries
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	33 // and attribute data from a WFS service.
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	34 type WaterwayArea struct {
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	35 // URL the GetCapabilities URL of the WFS service.
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	36 URL string `json:"url"`
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	37 // FeatureType selects the feature type of the WFS service.
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	38 FeatureType string `json:"feature-type"`
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	39 // SortBy works around misconfigured services to
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	40 // establish a sort order to get the features.
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	41 SortBy string `json:"sort-by"`
2723 a10022399e24 WFS downloads: Fetch user and password from config. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2721 diff changeset	42 // User is an optional username for Basic Auth.
a10022399e24 WFS downloads: Fetch user and password from config. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2721 diff changeset	43 User string `json:"user,omitempty"`
a10022399e24 WFS downloads: Fetch user and password from config. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2721 diff changeset	44 // Password is an optional password for Basic Auth.
a10022399e24 WFS downloads: Fetch user and password from config. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2721 diff changeset	45 Password string `json:"password,omitempty"`
1785 614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	46 }
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	47
4798 ca6a5f722471 Added Description method to most imports. Sascha Wilde <wilde@intevation.de> parents: 4197 diff changeset	48 func (wa *WaterwayArea) Description() (string, error) {
4799 f32d086b5dbf Removed the mechanical touch of the last commit. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 4798 diff changeset	49 return wa.URL + "\|" + wa.FeatureType, nil
4798 ca6a5f722471 Added Description method to most imports. Sascha Wilde <wilde@intevation.de> parents: 4197 diff changeset	50 }
ca6a5f722471 Added Description method to most imports. Sascha Wilde <wilde@intevation.de> parents: 4197 diff changeset	51
1785 614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	52 // WAJobKind is the import queue type identifier.
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	53 const WAJobKind JobKind = "wa"
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	54
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	55 type waJobCreator struct{}
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	56
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	57 func init() {
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	58 RegisterJobCreator(WAJobKind, waJobCreator{})
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	59 }
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	60
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	61 func (waJobCreator) Description() string { return "waterway area" }
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	62
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	63 func (waJobCreator) AutoAccept() bool { return true }
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	64
2187 7c83b5277c1c Import queue: Removed boilerplate code to deserialize jobs from JSON by making it part of the import queue. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2168 diff changeset	65 func (waJobCreator) Create() Job { return new(WaterwayArea) }
1785 614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	66
3219 4acbee65275d Import queue: Split locked dependencies in exclusively and multiple uses. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2938 diff changeset	67 func (waJobCreator) Depends() [2][]string {
4acbee65275d Import queue: Split locked dependencies in exclusively and multiple uses. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2938 diff changeset	68 return [2][]string{
4acbee65275d Import queue: Split locked dependencies in exclusively and multiple uses. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2938 diff changeset	69 {"waterway_area"},
4acbee65275d Import queue: Split locked dependencies in exclusively and multiple uses. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2938 diff changeset	70 {},
1785 614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	71 }
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	72 }
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	73
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	74 // StageDone is a NOP for waterway area imports.
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	75 func (waJobCreator) StageDone(context.Context, *sql.Tx, int64) error {
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	76 return nil
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	77 }
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	78
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	79 // CleanUp for waterway area imports is a NOP.
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	80 func (*WaterwayArea) CleanUp() error { return nil }
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	81
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	82 type waterwayAreaProperties struct {
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	83 Catccl *string `json:"ienc_catccl"`
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	84 Dirimp *string `json:"ienc_dirimp"`
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	85 }
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	86
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	87 const (
1796 904c7e853adc Waterway area import: Clip features against responsibility area. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1786 diff changeset	88 deleteWaterwayAreaSQL = `
904c7e853adc Waterway area import: Clip features against responsibility area. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1786 diff changeset	89 WITH resp AS (
2912 93fa55bce126 Add utility function to get users area of responsibility Tom Gottfried <tom@intevation.de> parents: 2855 diff changeset	90 SELECT users.current_user_area_utm() AS a
1796 904c7e853adc Waterway area import: Clip features against responsibility area. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1786 diff changeset	91 )
904c7e853adc Waterway area import: Clip features against responsibility area. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1786 diff changeset	92 DELETE FROM waterway.waterway_area
2649 9b6a02923bb4 Allow sys_admin to import waterway axis and area without clipping Tom Gottfried <tom@intevation.de> parents: 2622 diff changeset	93 WHERE pg_has_role('sys_admin', 'MEMBER')
9b6a02923bb4 Allow sys_admin to import waterway axis and area without clipping Tom Gottfried <tom@intevation.de> parents: 2622 diff changeset	94 OR ST_Covers((SELECT a FROM resp),
2912 93fa55bce126 Add utility function to get users area of responsibility Tom Gottfried <tom@intevation.de> parents: 2855 diff changeset	95 ST_Transform(area::geometry, (SELECT ST_SRID(a) FROM resp)))
1796 904c7e853adc Waterway area import: Clip features against responsibility area. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1786 diff changeset	96 `
1785 614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	97 insertWaterwayAreaSQL = `
1796 904c7e853adc Waterway area import: Clip features against responsibility area. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1786 diff changeset	98 WITH resp AS (
2912 93fa55bce126 Add utility function to get users area of responsibility Tom Gottfried <tom@intevation.de> parents: 2855 diff changeset	99 SELECT users.current_user_area_utm() AS a
1796 904c7e853adc Waterway area import: Clip features against responsibility area. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1786 diff changeset	100 )
1785 614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	101 INSERT INTO waterway.waterway_area (area, catccl, dirimp)
2855 8a8a929182f9 Enable import of axis and area independently from areas of responsibility Tom Gottfried <tom@intevation.de> parents: 2833 diff changeset	102 SELECT dmp.geom, $3, $4
8a8a929182f9 Enable import of axis and area independently from areas of responsibility Tom Gottfried <tom@intevation.de> parents: 2833 diff changeset	103 FROM ST_GeomFromWKB($1, $2::integer) AS new_area (new_area),
4844 58642179e896 Fix possibly invalid geometry output from transformation Tom Gottfried <tom@intevation.de> parents: 4832 diff changeset	104 ST_Dump(ST_CollectionExtract(ST_MakeValid(ST_Transform(
2649 9b6a02923bb4 Allow sys_admin to import waterway axis and area without clipping Tom Gottfried <tom@intevation.de> parents: 2622 diff changeset	105 CASE WHEN pg_has_role('sys_admin', 'MEMBER')
4844 58642179e896 Fix possibly invalid geometry output from transformation Tom Gottfried <tom@intevation.de> parents: 4832 diff changeset	106 THEN new_area
2855 8a8a929182f9 Enable import of axis and area independently from areas of responsibility Tom Gottfried <tom@intevation.de> parents: 2833 diff changeset	107 ELSE ST_Intersection((SELECT a FROM resp),
2912 93fa55bce126 Add utility function to get users area of responsibility Tom Gottfried <tom@intevation.de> parents: 2855 diff changeset	108 ST_MakeValid(ST_Transform(new_area, (SELECT ST_SRID(a) FROM resp))))
2855 8a8a929182f9 Enable import of axis and area independently from areas of responsibility Tom Gottfried <tom@intevation.de> parents: 2833 diff changeset	109 END,
4844 58642179e896 Fix possibly invalid geometry output from transformation Tom Gottfried <tom@intevation.de> parents: 4832 diff changeset	110 4326)), 3)) AS dmp
2938 ecb1e34157a3 Fix logging in area import Tom Gottfried <tom@intevation.de> parents: 2912 diff changeset	111 RETURNING id
1796 904c7e853adc Waterway area import: Clip features against responsibility area. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1786 diff changeset	112 `
1785 614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	113 )
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	114
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	115 // Do executes the actual waterway axis import.
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	116 func (wx *WaterwayArea) Do(
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	117 ctx context.Context,
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	118 importID int64,
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	119 conn *sql.Conn,
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	120 feedback Feedback,
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	121 ) (interface{}, error) {
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	122
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	123 start := time.Now()
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	124
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	125 feedback.Info("Import waterway area")
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	126
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	127 feedback.Info("Loading capabilities from %s", wx.URL)
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	128 caps, err := wfs.GetCapabilities(wx.URL)
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	129 if err != nil {
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	130 feedback.Error("Loading capabilities failed: %v", err)
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	131 return nil, err
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	132 }
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	133
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	134 ft := caps.FindFeatureType(wx.FeatureType)
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	135 if ft == nil {
4177 8b75ac5e243e Made 'staticcheck' happy with pgxutils package. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 4147 diff changeset	136 return nil, fmt.Errorf("unknown feature type '%s'", wx.FeatureType)
1785 614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	137 }
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	138
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	139 feedback.Info("Found feature type '%s", wx.FeatureType)
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	140
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	141 epsg, err := wfs.CRSToEPSG(ft.DefaultCRS)
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	142 if err != nil {
4832 5062ccb2381d Unified error message on "Unsupported CRS" Sascha Wilde <wilde@intevation.de> parents: 4799 diff changeset	143 feedback.Error("Unsupported CRS: '%s'", ft.DefaultCRS)
1785 614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	144 return nil, err
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	145 }
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	146
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	147 if wx.SortBy != "" {
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	148 feedback.Info("Features will be sorted by '%s'", wx.SortBy)
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	149 }
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	150
2721 56c8ef515d93 WFS downloader: Use new GML/GeoJSON factory function in gemma. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2719 diff changeset	151 dl, err := wfs.GetFeatures(caps, wx.FeatureType, wx.SortBy)
1785 614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	152 if err != nil {
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	153 feedback.Error("Cannot create GetFeature URLs. %v", err)
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	154 return nil, err
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	155 }
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	156
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	157 tx, err := conn.BeginTx(ctx, nil)
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	158 if err != nil {
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	159 return nil, err
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	160 }
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	161 defer tx.Rollback()
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	162
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	163 insertStmt, err := tx.PrepareContext(ctx, insertWaterwayAreaSQL)
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	164 if err != nil {
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	165 return nil, err
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	166 }
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	167 defer insertStmt.Close()
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	168
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	169 // Delete the old features.
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	170 if _, err := tx.ExecContext(ctx, deleteWaterwayAreaSQL); err != nil {
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	171 return nil, err
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	172 }
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	173
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	174 var (
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	175 unsupported = stringCounter{}
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	176 missingProperties int
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	177 badProperties int
2938 ecb1e34157a3 Fix logging in area import Tom Gottfried <tom@intevation.de> parents: 2912 diff changeset	178 outside int
1785 614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	179 features int
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	180 )
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	181
2729 7cb027be277d WFS downloader: Really use username and password from parameters. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2723 diff changeset	182 if err := dl.Download(wx.User, wx.Password, func(url string, r io.Reader) error {
2106 2b72f5e005aa WFS imports: Write get GetFeature URLs into import log. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1899 diff changeset	183 feedback.Info("Get features from: '%s'", url)
1785 614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	184 rfc, err := wfs.ParseRawFeatureCollection(r)
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	185 if err != nil {
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	186 return fmt.Errorf("parsing GetFeature document failed: %v", err)
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	187 }
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	188 if rfc.CRS != nil {
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	189 crsName := rfc.CRS.Properties.Name
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	190 if epsg, err = wfs.CRSToEPSG(crsName); err != nil {
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	191 feedback.Error("Unsupported CRS: %d", crsName)
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	192 return err
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	193 }
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	194 }
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	195
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	196 // No features -> ignore.
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	197 if rfc.Features == nil {
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	198 return nil
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	199 }
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	200
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	201 feedback.Info("Using EPSG: %d", epsg)
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	202
2758 a996f2ca9fa5 Simplified savepoint handling. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2729 diff changeset	203 savepoint := Savepoint(ctx, tx, "feature")
2659 00b0a7b2225a Waterway area import: do not fail if INSERT of one item fails Tom Gottfried <tom@intevation.de> parents: 2649 diff changeset	204
1785 614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	205 for _, feature := range rfc.Features {
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	206 if feature.Properties == nil \|\| feature.Geometry.Coordinates == nil {
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	207 missingProperties++
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	208 continue
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	209 }
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	210
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	211 var props waterwayAreaProperties
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	212
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	213 if err := json.Unmarshal(*feature.Properties, &props); err != nil {
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	214 badProperties++
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	215 continue
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	216 }
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	217
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	218 var catccl sql.NullInt64
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	219 if props.Catccl != nil {
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	220 if value, err := strconv.ParseInt(*props.Catccl, 10, 64); err == nil {
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	221 catccl = sql.NullInt64{Int64: value, Valid: true}
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	222 }
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	223 }
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	224 var dirimp sql.NullInt64
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	225 if props.Dirimp != nil {
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	226 if value, err := strconv.ParseInt(*props.Dirimp, 10, 64); err == nil {
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	227 dirimp = sql.NullInt64{Int64: value, Valid: true}
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	228 }
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	229 }
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	230
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	231 switch feature.Geometry.Type {
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	232 case "Polygon":
1786 09349ca27dd7 Imports: Removed duplicated code path to store WKB polygons into database. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1785 diff changeset	233 var p polygonSlice
1785 614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	234 if err := json.Unmarshal(*feature.Geometry.Coordinates, &p); err != nil {
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	235 return err
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	236 }
2938 ecb1e34157a3 Fix logging in area import Tom Gottfried <tom@intevation.de> parents: 2912 diff changeset	237 var waid int64
ecb1e34157a3 Fix logging in area import Tom Gottfried <tom@intevation.de> parents: 2912 diff changeset	238 err := savepoint(func() error {
ecb1e34157a3 Fix logging in area import Tom Gottfried <tom@intevation.de> parents: 2912 diff changeset	239 err := insertStmt.QueryRowContext(
2758 a996f2ca9fa5 Simplified savepoint handling. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2729 diff changeset	240 ctx,
a996f2ca9fa5 Simplified savepoint handling. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2729 diff changeset	241 p.asWKB(),
a996f2ca9fa5 Simplified savepoint handling. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2729 diff changeset	242 epsg,
a996f2ca9fa5 Simplified savepoint handling. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2729 diff changeset	243 catccl,
a996f2ca9fa5 Simplified savepoint handling. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 2729 diff changeset	244 dirimp,
2938 ecb1e34157a3 Fix logging in area import Tom Gottfried <tom@intevation.de> parents: 2912 diff changeset	245 ).Scan(&waid)
2659 00b0a7b2225a Waterway area import: do not fail if INSERT of one item fails Tom Gottfried <tom@intevation.de> parents: 2649 diff changeset	246 return err
2938 ecb1e34157a3 Fix logging in area import Tom Gottfried <tom@intevation.de> parents: 2912 diff changeset	247 })
ecb1e34157a3 Fix logging in area import Tom Gottfried <tom@intevation.de> parents: 2912 diff changeset	248 switch {
ecb1e34157a3 Fix logging in area import Tom Gottfried <tom@intevation.de> parents: 2912 diff changeset	249 case err == sql.ErrNoRows:
ecb1e34157a3 Fix logging in area import Tom Gottfried <tom@intevation.de> parents: 2912 diff changeset	250 outside++
ecb1e34157a3 Fix logging in area import Tom Gottfried <tom@intevation.de> parents: 2912 diff changeset	251 // ignore -> filtered by responsibility_areas
ecb1e34157a3 Fix logging in area import Tom Gottfried <tom@intevation.de> parents: 2912 diff changeset	252 case err != nil:
4197 5d7ce7f926eb Log fatal errors as errors, not warnings, in imports Tom Gottfried <tom@intevation.de> parents: 4177 diff changeset	253 feedback.Error(pgxutils.ReadableError{Err: err}.Error())
2938 ecb1e34157a3 Fix logging in area import Tom Gottfried <tom@intevation.de> parents: 2912 diff changeset	254 default:
2659 00b0a7b2225a Waterway area import: do not fail if INSERT of one item fails Tom Gottfried <tom@intevation.de> parents: 2649 diff changeset	255 features++
1785 614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	256 }
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	257 default:
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	258 unsupported[feature.Geometry.Type]++
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	259 }
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	260 }
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	261 return nil
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	262 }); err != nil {
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	263 return nil, err
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	264 }
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	265
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	266 if badProperties > 0 {
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	267 feedback.Warn("Bad properties: %d", badProperties)
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	268 }
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	269
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	270 if missingProperties > 0 {
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	271 feedback.Warn("Missing properties: %d", missingProperties)
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	272 }
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	273
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	274 if len(unsupported) != 0 {
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	275 feedback.Warn("Unsupported types found: %s", unsupported)
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	276 }
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	277
2938 ecb1e34157a3 Fix logging in area import Tom Gottfried <tom@intevation.de> parents: 2912 diff changeset	278 if outside > 0 {
ecb1e34157a3 Fix logging in area import Tom Gottfried <tom@intevation.de> parents: 2912 diff changeset	279 feedback.Info("Features outside responsibility area: %d", outside)
ecb1e34157a3 Fix logging in area import Tom Gottfried <tom@intevation.de> parents: 2912 diff changeset	280 }
ecb1e34157a3 Fix logging in area import Tom Gottfried <tom@intevation.de> parents: 2912 diff changeset	281
1828 1ecfcf46e4da Waterway area/axis: Be more informative if features are bad. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1796 diff changeset	282 if features == 0 {
4177 8b75ac5e243e Made 'staticcheck' happy with pgxutils package. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 4147 diff changeset	283 err := errors.New("no features found")
1828 1ecfcf46e4da Waterway area/axis: Be more informative if features are bad. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1796 diff changeset	284 feedback.Error("%v", err)
1ecfcf46e4da Waterway area/axis: Be more informative if features are bad. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1796 diff changeset	285 return nil, err
1ecfcf46e4da Waterway area/axis: Be more informative if features are bad. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1796 diff changeset	286 }
1ecfcf46e4da Waterway area/axis: Be more informative if features are bad. Sascha L. Teichmann <sascha.teichmann@intevation.de> parents: 1796 diff changeset	287
1785 614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	288 if err = tx.Commit(); err == nil {
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	289 feedback.Info("Storing %d features took %s",
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	290 features, time.Since(start))
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	291 }
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	292
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	293 return nil, err
614c6c766691 Waterway area import: Implemented. Sascha L. Teichmann <teichmann@intevation.de> parents: diff changeset	294 }

Mercurial > gemma

annotate pkg/imports/wa.go @ 4844:58642179e896