changeset 5035:56c589f7435d

Enhance comments on implementations of StageDone()
author Tom Gottfried <tom@intevation.de>
date Fri, 20 Mar 2020 17:24:03 +0100
parents 59a99655f34d
children b47f2e3e0a75 1154b73328ec 445daeefca7b
files pkg/imports/agm.go pkg/imports/fa.go pkg/imports/fd.go pkg/imports/gm.go pkg/imports/isr.go pkg/imports/sr.go pkg/imports/ufa.go pkg/imports/ugm.go pkg/imports/wp.go
diffstat 9 files changed, 9 insertions(+), 4 deletions(-) [+]
line wrap: on
line diff
--- a/pkg/imports/agm.go	Fri Mar 20 12:28:04 2020 +0100
+++ b/pkg/imports/agm.go	Fri Mar 20 17:24:03 2020 +0100
@@ -88,6 +88,7 @@
 )`
 )
 
+// StageDone replaces gauge measurements with those in the staging area
 func (agmJobCreator) StageDone(
 	ctx context.Context,
 	tx *sql.Tx,
--- a/pkg/imports/fa.go	Fri Mar 20 12:28:04 2020 +0100
+++ b/pkg/imports/fa.go	Fri Mar 20 17:24:03 2020 +0100
@@ -187,8 +187,7 @@
 
 func (faJobCreator) AutoAccept() bool { return true }
 
-// StageDone moves the imported fairway availablities out of the staging area.
-// Currently doing nothing.
+// StageDone is a NOP for fairway availability imports.
 func (faJobCreator) StageDone(context.Context, *sql.Tx, int64, Feedback) error {
 	return nil
 }
--- a/pkg/imports/fd.go	Fri Mar 20 12:28:04 2020 +0100
+++ b/pkg/imports/fd.go	Fri Mar 20 17:24:03 2020 +0100
@@ -98,6 +98,7 @@
 	}
 }
 
+// StageDone replaces fairway dimensions with those in the staging area
 func (fdJobCreator) StageDone(
 	ctx context.Context,
 	tx *sql.Tx,
--- a/pkg/imports/gm.go	Fri Mar 20 12:28:04 2020 +0100
+++ b/pkg/imports/gm.go	Fri Mar 20 17:24:03 2020 +0100
@@ -145,8 +145,7 @@
 
 func (gmJobCreator) AutoAccept() bool { return true }
 
-// StageDone moves the imported gauge measurement out of the staging area.
-// Currently doing nothing.
+// StageDone is a NOP for gauge measurements imports.
 func (gmJobCreator) StageDone(context.Context, *sql.Tx, int64, Feedback) error {
 	return nil
 }
--- a/pkg/imports/isr.go	Fri Mar 20 12:28:04 2020 +0100
+++ b/pkg/imports/isr.go	Fri Mar 20 17:24:03 2020 +0100
@@ -41,6 +41,7 @@
 
 func (isrJobCreator) Create() Job { return new(IsoRefresh) }
 
+// StageDone is a NOP for IsoRefresh imports.
 func (isrJobCreator) StageDone(context.Context, *sql.Tx, int64, Feedback) error {
 	return nil
 }
--- a/pkg/imports/sr.go	Fri Mar 20 12:28:04 2020 +0100
+++ b/pkg/imports/sr.go	Fri Mar 20 17:24:03 2020 +0100
@@ -109,6 +109,7 @@
 	}
 }
 
+// StageDone moves the imported sounding result out of the staging area.
 func (srJobCreator) StageDone(
 	ctx context.Context,
 	tx *sql.Tx,
--- a/pkg/imports/ufa.go	Fri Mar 20 12:28:04 2020 +0100
+++ b/pkg/imports/ufa.go	Fri Mar 20 17:24:03 2020 +0100
@@ -51,6 +51,7 @@
 
 func (ufaJobCreator) AutoAccept() bool { return true }
 
+// StageDone is a NOP for fairway availability imports.
 func (ufaJobCreator) StageDone(context.Context, *sql.Tx, int64, Feedback) error {
 	return nil
 }
--- a/pkg/imports/ugm.go	Fri Mar 20 12:28:04 2020 +0100
+++ b/pkg/imports/ugm.go	Fri Mar 20 17:24:03 2020 +0100
@@ -45,6 +45,7 @@
 
 func (ugmJobCreator) AutoAccept() bool { return true }
 
+// StageDone is a NOP for gauge measurements imports.
 func (ugmJobCreator) StageDone(context.Context, *sql.Tx, int64, Feedback) error { return nil }
 
 // CleanUp removes the temporary files from the filesystem.
--- a/pkg/imports/wp.go	Fri Mar 20 12:28:04 2020 +0100
+++ b/pkg/imports/wp.go	Fri Mar 20 17:24:03 2020 +0100
@@ -149,6 +149,7 @@
     relation = 'waterway.waterway_profiles'::regclass)`
 )
 
+// StageDone moves the imported waterway profiles out of the staging area.
 func (wpJobCreator) StageDone(
 	ctx context.Context,
 	tx *sql.Tx,