changeset 3315:d61b88439c85

client: fairway availability: more appropriate property naming
author Markus Kottlaender <markus@intevation.de>
date Fri, 17 May 2019 14:41:28 +0200
parents 70676557a66f
children c7b48272e11e
files client/src/components/fairway/AvailableFairwayDepthDialogue.vue
diffstat 1 files changed, 10 insertions(+), 10 deletions(-) [+]
line wrap: on
line diff
--- a/client/src/components/fairway/AvailableFairwayDepthDialogue.vue	Fri May 17 14:08:09 2019 +0200
+++ b/client/src/components/fairway/AvailableFairwayDepthDialogue.vue	Fri May 17 14:41:28 2019 +0200
@@ -36,7 +36,7 @@
           class="form-control font-weight-bold"
           v-model="selectedEntry"
         >
-          <option :value="null">{{ empty }}</option>
+          <option :value="null">{{ placeholder }}</option>
           <optgroup
             v-for="(bottlenecksForCountry, cc) in orderedBottlenecks"
             :key="cc"
@@ -58,7 +58,7 @@
           class="form-control font-weight-bold"
           v-model="selectedEntry"
         >
-          <option :value="null">{{ empty }}</option>
+          <option :value="null">{{ placeholder }}</option>
           <option
             v-for="(entry, index) in entries"
             :value="entry"
@@ -120,14 +120,14 @@
         <div class="mt-3">
           <button
             @click="openFairwaydepthDiagram"
-            :disabled="isComplete"
+            :disabled="!isComplete"
             class="btn btn-info btn-sm d-block w-100"
           >
             <translate>Available fairway depth</translate>
           </button>
           <button
             @click="openFairwaydepthLNWLDiagram"
-            :disabled="isComplete"
+            :disabled="!isComplete"
             class="btn btn-info btn-sm d-block w-100 mt-2"
           >
             <translate>Available fairway depth vs LNWL</translate>
@@ -195,11 +195,11 @@
     ...mapGetters("bottlenecks", ["orderedBottlenecks"]),
     isComplete() {
       return (
-        this.from == null ||
-        this.to == null ||
-        this.frequency == null ||
-        this.los == null ||
-        this.selectedFairwayAvailabilityFeature == null
+        this.from !== null &&
+        this.to !== null &&
+        this.frequency !== null &&
+        this.los !== null &&
+        this.selectedFairwayAvailabilityFeature !== null
       );
     },
     type: {
@@ -262,7 +262,7 @@
     label() {
       return this.$gettext("Available fairway depth");
     },
-    empty() {
+    placeholder() {
       if (this.type === this.$options.BOTTLENECKS)
         return this.$gettext("Select bottleneck");
       if (this.type === this.$options.STRETCHES)