Mercurial > kallithea

annotate scripts/pyflakes @ 8297:2fa9f497faac

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
repos: separate repo creation from form validation The broad catching of Exception in the repo creation controller is conceptually bad. It also caused misleading "Error creating repository None" when form validation failed with anything but formencode.Invalid . For now, just constrain the broad exception handling to only cover repo creation. It is a bug if form validation fails in unexpected ways, and we want it reported as a crash that we can fix.
author Mads Kiilerich <mads@kiilerich.com>
date Tue, 17 Mar 2020 17:15:59 +0100
parents abb83e4edfd9
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
8240
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
1 #!/usr/bin/env python3
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
2 """
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
3 pyflakes with filter configuration for Kallithea.
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
4 Inspired by pyflakes/api.py and flake8/plugins/pyflakes.py .
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
5 """
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
6
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
7 import sys
8287
abb83e4edfd9 scripts: run isort on scripts too
Mads Kiilerich <mads@kiilerich.com>
parents: 8240
diff changeset
8
8240
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
9 import pyflakes.api
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
10 import pyflakes.messages
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
11
8287
abb83e4edfd9 scripts: run isort on scripts too
Mads Kiilerich <mads@kiilerich.com>
parents: 8240
diff changeset
12
8240
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
13 class Reporter:
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
14
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
15 warned = False
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
16
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
17 def flake(self, warning):
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
18 # ignore known warnings
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
19 if isinstance(warning, pyflakes.messages.UnusedVariable):
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
20 return
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
21 if warning.filename == 'kallithea/bin/kallithea_cli_ishell.py':
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
22 if isinstance(warning, pyflakes.messages.ImportStarUsed) and warning.message_args == ('kallithea.model.db',):
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
23 return
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
24 if isinstance(warning, pyflakes.messages.UnusedImport) and warning.message_args == ('kallithea.model.db.*',):
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
25 return
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
26
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
27 print('%s:%s %s [%s %s]' % (warning.filename, warning.lineno, warning.message % warning.message_args, type(warning).__name__, warning.message_args))
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
28 self.warned = True
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
29
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
30 def unexpectedError(self, filename, msg):
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
31 print('Unexpected error for %s: %s' % (filename, msg))
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
32
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
33
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
34 reporter = Reporter()
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
35
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
36 for filename in sorted(set(sys.argv[1:])):
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
37 pyflakes.api.checkPath(filename, reporter=reporter)
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
38 if reporter.warned:
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
39 raise SystemExit(1)