annotate scripts/pyflakes @ 8240:51af7c12ffb1

cleanup: run pyflakes as a part of scripts/run-all-cleanup pyflakes has no usable configuration options, so create a small wrapper script. Instead of having two wrapper scripts (with one being almost nothing and the other containing configuration), just keep it simple and use one combined.
author Mads Kiilerich <mads@kiilerich.com>
date Tue, 11 Feb 2020 05:17:03 +0100
parents
children abb83e4edfd9
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
8240
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
1 #!/usr/bin/env python3
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
2 """
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
3 pyflakes with filter configuration for Kallithea.
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
4 Inspired by pyflakes/api.py and flake8/plugins/pyflakes.py .
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
5 """
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
6
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
7 import sys
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
8 import pyflakes.api
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
9 import pyflakes.messages
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
10
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
11 class Reporter:
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
12
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
13 warned = False
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
14
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
15 def flake(self, warning):
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
16 # ignore known warnings
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
17 if isinstance(warning, pyflakes.messages.UnusedVariable):
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
18 return
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
19 if warning.filename == 'kallithea/bin/kallithea_cli_ishell.py':
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
20 if isinstance(warning, pyflakes.messages.ImportStarUsed) and warning.message_args == ('kallithea.model.db',):
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
21 return
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
22 if isinstance(warning, pyflakes.messages.UnusedImport) and warning.message_args == ('kallithea.model.db.*',):
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
23 return
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
24
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
25 print('%s:%s %s [%s %s]' % (warning.filename, warning.lineno, warning.message % warning.message_args, type(warning).__name__, warning.message_args))
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
26 self.warned = True
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
27
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
28 def unexpectedError(self, filename, msg):
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
29 print('Unexpected error for %s: %s' % (filename, msg))
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
30
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
31
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
32 reporter = Reporter()
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
33
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
34 for filename in sorted(set(sys.argv[1:])):
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
35 pyflakes.api.checkPath(filename, reporter=reporter)
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
36 if reporter.warned:
51af7c12ffb1 cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff changeset
37 raise SystemExit(1)