Mercurial > kallithea
comparison rhodecode/templates/pullrequests/pullrequest_show_all.html @ 3652:8a8a559eaf95 beta
pullrequests: state "closed" explicitly
A closed-as-in-locked icon did not communicate the closed-as-in-inactive state
clearly.
Instead we say "Closed" and make the text greyed out. Not pretty but more
efficient.
author | Mads Kiilerich <madski@unity3d.com> |
---|---|
date | Wed, 03 Apr 2013 15:56:12 +0200 |
parents | 2ea981f9da79 |
children | 9d2db665ef31 |
comparison
equal
deleted
inserted
replaced
3651:659bd922520e | 3652:8a8a559eaf95 |
---|---|
19 <div class="title"> | 19 <div class="title"> |
20 ${self.breadcrumbs()} | 20 ${self.breadcrumbs()} |
21 </div> | 21 </div> |
22 | 22 |
23 %for pr in c.pull_requests: | 23 %for pr in c.pull_requests: |
24 <div> | 24 <div class="${'closed' if pr.is_closed() else ''}"> |
25 <h4 style="border:0px;padding:0px"> | 25 <h4 style="border:0px;padding:0px"> |
26 %if pr.is_closed(): | |
27 <img src="${h.url('/images/icons/lock_go.png')}" title="${_('Closed')}"/> | |
28 %endif | |
29 <img src="${h.url('/images/icons/flag_status_%s.png' % str(pr.last_review_status))}" /> | 26 <img src="${h.url('/images/icons/flag_status_%s.png' % str(pr.last_review_status))}" /> |
30 <a href="${h.url('pullrequest_show',repo_name=c.repo_name,pull_request_id=pr.pull_request_id)}"> | 27 <a href="${h.url('pullrequest_show',repo_name=c.repo_name,pull_request_id=pr.pull_request_id)}"> |
31 ${_('Pull request #%s opened by %s on %s') % (pr.pull_request_id, pr.author.full_name, h.fmt_date(pr.created_on))} | 28 ${_('Pull request #%s opened by %s on %s') % (pr.pull_request_id, pr.author.full_name, h.fmt_date(pr.created_on))} |
32 </a> | 29 </a> |
30 %if pr.is_closed(): | |
31 (${_('Closed')}) | |
32 %endif | |
33 </h4> | 33 </h4> |
34 <h5 style="border:0px;padding-bottom:0px">${_('Title')}: ${pr.title}</h5> | 34 <h5 style="border:0px;padding-bottom:0px">${_('Title')}: ${pr.title}</h5> |
35 <div style="padding:0px 24px">${pr.description}</div> | 35 <div style="padding:0px 24px">${pr.description}</div> |
36 <div style="border-bottom: 1px solid #DDD;margin:10px 20px;padding-bottom:10px"></div> | 36 <div style="border-bottom: 1px solid #DDD;margin:10px 20px;padding-bottom:10px"></div> |
37 </div> | 37 </div> |