Mercurial > kallithea
diff rhodecode/templates/pullrequests/pullrequest_show_all.html @ 3652:8a8a559eaf95 beta
pullrequests: state "closed" explicitly
A closed-as-in-locked icon did not communicate the closed-as-in-inactive state
clearly.
Instead we say "Closed" and make the text greyed out. Not pretty but more
efficient.
| author | Mads Kiilerich <madski@unity3d.com> |
|---|---|
| date | Wed, 03 Apr 2013 15:56:12 +0200 |
| parents | 2ea981f9da79 |
| children | 9d2db665ef31 |
line wrap: on
line diff
--- a/rhodecode/templates/pullrequests/pullrequest_show_all.html Wed Apr 03 15:56:12 2013 +0200 +++ b/rhodecode/templates/pullrequests/pullrequest_show_all.html Wed Apr 03 15:56:12 2013 +0200 @@ -21,15 +21,15 @@ </div> %for pr in c.pull_requests: - <div> - <h4 style="border:0px;padding:0px"> - %if pr.is_closed(): - <img src="${h.url('/images/icons/lock_go.png')}" title="${_('Closed')}"/> - %endif + <div class="${'closed' if pr.is_closed() else ''}"> + <h4 style="border:0px;padding:0px"> <img src="${h.url('/images/icons/flag_status_%s.png' % str(pr.last_review_status))}" /> <a href="${h.url('pullrequest_show',repo_name=c.repo_name,pull_request_id=pr.pull_request_id)}"> ${_('Pull request #%s opened by %s on %s') % (pr.pull_request_id, pr.author.full_name, h.fmt_date(pr.created_on))} </a> + %if pr.is_closed(): + (${_('Closed')}) + %endif </h4> <h5 style="border:0px;padding-bottom:0px">${_('Title')}: ${pr.title}</h5> <div style="padding:0px 24px">${pr.description}</div>