view scripts/pyflakes @ 8759:0b1a23b88f9a

cleanup: get rid of redundant assignments 'foo = foo' Redundant assignments were searched with: grep '^ *\(.*\) = \1$' `hg files` Some of these cases have resulted from earlier cleanup, like: foo = safe_unicode(foo) and later batch removing safe_unicode usage. See e.g. commit e35373106528b29461b7f5144780cb9ec79f765d . Note: two false positives occur: kallithea/tests/models/test_settings.py:39: setting.app_settings_value = setting.app_settings_value kallithea/tests/models/test_settings.py:42: setting.app_settings_value = setting.app_settings_value which is not a plain assignment but where 'app_settings_value' is a property method with side effects.
author Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
date Sat, 07 Nov 2020 20:59:03 +0100
parents abb83e4edfd9
children
line wrap: on
line source

#!/usr/bin/env python3
"""
pyflakes with filter configuration for Kallithea.
Inspired by pyflakes/api.py and flake8/plugins/pyflakes.py .
"""

import sys

import pyflakes.api
import pyflakes.messages


class Reporter:

    warned = False

    def flake(self, warning):
        # ignore known warnings
        if isinstance(warning, pyflakes.messages.UnusedVariable):
            return
        if warning.filename == 'kallithea/bin/kallithea_cli_ishell.py':
            if isinstance(warning, pyflakes.messages.ImportStarUsed) and warning.message_args == ('kallithea.model.db',):
                return
            if isinstance(warning, pyflakes.messages.UnusedImport) and warning.message_args == ('kallithea.model.db.*',):
                return

        print('%s:%s %s   [%s %s]' % (warning.filename, warning.lineno, warning.message % warning.message_args, type(warning).__name__, warning.message_args))
        self.warned = True

    def unexpectedError(self, filename, msg):
        print('Unexpected error for %s: %s' % (filename, msg))


reporter = Reporter()

for filename in sorted(set(sys.argv[1:])):
    pyflakes.api.checkPath(filename, reporter=reporter)
if reporter.warned:
    raise SystemExit(1)