Mercurial > kallithea
annotate scripts/pyflakes @ 8759:0b1a23b88f9a
cleanup: get rid of redundant assignments 'foo = foo'
Redundant assignments were searched with:
grep '^ *\(.*\) = \1$' `hg files`
Some of these cases have resulted from earlier cleanup, like:
foo = safe_unicode(foo)
and later batch removing safe_unicode usage. See e.g. commit
e35373106528b29461b7f5144780cb9ec79f765d .
Note: two false positives occur:
kallithea/tests/models/test_settings.py:39:
setting.app_settings_value = setting.app_settings_value
kallithea/tests/models/test_settings.py:42:
setting.app_settings_value = setting.app_settings_value
which is not a plain assignment but where 'app_settings_value' is a property
method with side effects.
author | Thomas De Schampheleire <thomas.de_schampheleire@nokia.com> |
---|---|
date | Sat, 07 Nov 2020 20:59:03 +0100 |
parents | abb83e4edfd9 |
children |
rev | line source |
---|---|
8240
51af7c12ffb1
cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff
changeset
|
1 #!/usr/bin/env python3 |
51af7c12ffb1
cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff
changeset
|
2 """ |
51af7c12ffb1
cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff
changeset
|
3 pyflakes with filter configuration for Kallithea. |
51af7c12ffb1
cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff
changeset
|
4 Inspired by pyflakes/api.py and flake8/plugins/pyflakes.py . |
51af7c12ffb1
cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff
changeset
|
5 """ |
51af7c12ffb1
cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff
changeset
|
6 |
51af7c12ffb1
cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff
changeset
|
7 import sys |
8287
abb83e4edfd9
scripts: run isort on scripts too
Mads Kiilerich <mads@kiilerich.com>
parents:
8240
diff
changeset
|
8 |
8240
51af7c12ffb1
cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff
changeset
|
9 import pyflakes.api |
51af7c12ffb1
cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff
changeset
|
10 import pyflakes.messages |
51af7c12ffb1
cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff
changeset
|
11 |
8287
abb83e4edfd9
scripts: run isort on scripts too
Mads Kiilerich <mads@kiilerich.com>
parents:
8240
diff
changeset
|
12 |
8240
51af7c12ffb1
cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff
changeset
|
13 class Reporter: |
51af7c12ffb1
cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff
changeset
|
14 |
51af7c12ffb1
cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff
changeset
|
15 warned = False |
51af7c12ffb1
cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff
changeset
|
16 |
51af7c12ffb1
cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff
changeset
|
17 def flake(self, warning): |
51af7c12ffb1
cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff
changeset
|
18 # ignore known warnings |
51af7c12ffb1
cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff
changeset
|
19 if isinstance(warning, pyflakes.messages.UnusedVariable): |
51af7c12ffb1
cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff
changeset
|
20 return |
51af7c12ffb1
cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff
changeset
|
21 if warning.filename == 'kallithea/bin/kallithea_cli_ishell.py': |
51af7c12ffb1
cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff
changeset
|
22 if isinstance(warning, pyflakes.messages.ImportStarUsed) and warning.message_args == ('kallithea.model.db',): |
51af7c12ffb1
cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff
changeset
|
23 return |
51af7c12ffb1
cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff
changeset
|
24 if isinstance(warning, pyflakes.messages.UnusedImport) and warning.message_args == ('kallithea.model.db.*',): |
51af7c12ffb1
cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff
changeset
|
25 return |
51af7c12ffb1
cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff
changeset
|
26 |
51af7c12ffb1
cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff
changeset
|
27 print('%s:%s %s [%s %s]' % (warning.filename, warning.lineno, warning.message % warning.message_args, type(warning).__name__, warning.message_args)) |
51af7c12ffb1
cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff
changeset
|
28 self.warned = True |
51af7c12ffb1
cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff
changeset
|
29 |
51af7c12ffb1
cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff
changeset
|
30 def unexpectedError(self, filename, msg): |
51af7c12ffb1
cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff
changeset
|
31 print('Unexpected error for %s: %s' % (filename, msg)) |
51af7c12ffb1
cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff
changeset
|
32 |
51af7c12ffb1
cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff
changeset
|
33 |
51af7c12ffb1
cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff
changeset
|
34 reporter = Reporter() |
51af7c12ffb1
cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff
changeset
|
35 |
51af7c12ffb1
cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff
changeset
|
36 for filename in sorted(set(sys.argv[1:])): |
51af7c12ffb1
cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff
changeset
|
37 pyflakes.api.checkPath(filename, reporter=reporter) |
51af7c12ffb1
cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff
changeset
|
38 if reporter.warned: |
51af7c12ffb1
cleanup: run pyflakes as a part of scripts/run-all-cleanup
Mads Kiilerich <mads@kiilerich.com>
parents:
diff
changeset
|
39 raise SystemExit(1) |