changeset 8820:0270c714fa17

celery: drop traces of support for task_always_eager It was broken - retrieval of results didn't work. Also, task_always_eager still require a working celery.broker_url even though it is unused. It is thus much better to just set use_celery=false .
author Mads Kiilerich <mads@kiilerich.com>
date Sat, 26 Dec 2020 20:21:24 +0100
parents 43ad0cec9037
children a5c17c93d246
files development.ini kallithea/lib/celery_app.py kallithea/templates/ini/template.ini.mako
diffstat 3 files changed, 1 insertions(+), 6 deletions(-) [+]
line wrap: on
line diff
--- a/development.ini	Mon Dec 28 00:04:26 2020 +0100
+++ b/development.ini	Sat Dec 26 20:21:24 2020 +0100
@@ -266,9 +266,6 @@
 celery.worker_concurrency = 2
 celery.worker_max_tasks_per_child = 100
 
-## If true, tasks will never be sent to the queue, but executed locally instead.
-celery.task_always_eager = false
-
 ####################################
 ##          BEAKER CACHE          ##
 ####################################
--- a/kallithea/lib/celery_app.py	Mon Dec 28 00:04:26 2020 +0100
+++ b/kallithea/lib/celery_app.py	Sat Dec 26 20:21:24 2020 +0100
@@ -39,6 +39,7 @@
     'celery.result.serialier',
     'celery.result.serializer',
     'celery.send.task.error.emails',
+    'celery.task_always_eager',  # still a valid configuration in celery, but not supported in Kallithea
     'celery.task.serializer',
 ])
 
--- a/kallithea/templates/ini/template.ini.mako	Mon Dec 28 00:04:26 2020 +0100
+++ b/kallithea/templates/ini/template.ini.mako	Sat Dec 26 20:21:24 2020 +0100
@@ -341,9 +341,6 @@
 celery.worker_concurrency = 2
 celery.worker_max_tasks_per_child = 100
 
-<%text>##</%text> If true, tasks will never be sent to the queue, but executed locally instead.
-celery.task_always_eager = false
-
 <%text>##</%text>##################################
 <%text>##</%text>          BEAKER CACHE          ##
 <%text>##</%text>##################################