Mercurial > kallithea
changeset 5311:1528ae42ec04
pullrequests: drop the useless 'latest vote' column
| author | Mads Kiilerich <madski@unity3d.com> |
|---|---|
| date | Fri, 24 Jul 2015 16:37:40 +0200 |
| parents | 2aa8206cd193 |
| children | 910c0a039f2a |
| files | kallithea/model/db.py kallithea/templates/pullrequests/pullrequest_data.html |
| diffstat | 2 files changed, 1 insertions(+), 12 deletions(-) [+] |
line wrap: on
line diff
--- a/kallithea/model/db.py Fri Jul 24 16:37:40 2015 +0200 +++ b/kallithea/model/db.py Fri Jul 24 16:37:40 2015 +0200 @@ -2319,10 +2319,6 @@ def is_closed(self): return self.status == self.STATUS_CLOSED - @property - def last_review_status(self): - return str(self.statuses[-1].status) if self.statuses else '' - def user_review_status(self, user_id): """Return the user's latest status votes on PR""" # note: no filtering on repo - that would be redundant
--- a/kallithea/templates/pullrequests/pullrequest_data.html Fri Jul 24 16:37:40 2015 +0200 +++ b/kallithea/templates/pullrequests/pullrequest_data.html Fri Jul 24 16:37:40 2015 +0200 @@ -11,7 +11,7 @@ <table> <thead> <tr> - <th></th> + <th class="left">${_('Vote')}</th> <th class="left">${_('Title')}</th> <th class="left">${_('Author')}</th> <th class="left">${_('Age')}</th> @@ -22,13 +22,6 @@ % for pr in pullrequests: <tr class="${'pr-closed' if pr.is_closed() else ''}"> <td width="80px"> - ## review status - %if pr.last_review_status: - <i class="icon-circle changeset-status-${pr.last_review_status}" title="${_("Latest vote: %s") % pr.last_review_status}"></i> - %else: - <i class="icon-circle changeset-status-not_reviewed" title="${_("Nobody voted")}"></i> - %endif - <% status = pr.user_review_status(c.authuser.user_id) %> %if status: <i class="icon-circle changeset-status-${status}" title="${_("You voted: %s") % status}"></i>