Mercurial > kallithea
changeset 8275:169539b32b90
js: fix missing var declaration of AJAX_COMMENT_URL and AJAX_COMMENT_DELETE_URL (Issue #362)
Tech debt stroke back when fb9550946c26 cleaned things up.
Eslint wearnings for these variables had incorrectly been manually ignored.
| author | Mads Kiilerich <mads@kiilerich.com> |
|---|---|
| date | Tue, 25 Feb 2020 18:18:44 +0100 |
| parents | a42ab217f3d0 |
| children | fdde16d7cea0 |
| files | kallithea/public/js/base.js kallithea/templates/changeset/changeset.html kallithea/templates/pullrequests/pullrequest_show.html |
| diffstat | 3 files changed, 6 insertions(+), 4 deletions(-) [+] |
line wrap: on
line diff
--- a/kallithea/public/js/base.js Tue Feb 25 18:03:54 2020 +0100 +++ b/kallithea/public/js/base.js Tue Feb 25 18:18:44 2020 +0100 @@ -593,6 +593,7 @@ } // append a comment form to $comment_div +// Note: var AJAX_COMMENT_URL must have been defined before invoking this function function _comment_div_append_form($comment_div, f_path, line_no) { var $form_div = $('#comment-inline-form-template').children() .clone() @@ -709,6 +710,7 @@ } +// Note: var AJAX_COMMENT_URL must have been defined before invoking this function function deleteComment(comment_id) { var url = AJAX_COMMENT_DELETE_URL.replace('__COMMENT_ID__', comment_id); var postData = {};
--- a/kallithea/templates/changeset/changeset.html Tue Feb 25 18:03:54 2020 +0100 +++ b/kallithea/templates/changeset/changeset.html Tue Feb 25 18:18:44 2020 +0100 @@ -23,8 +23,8 @@ ${self.breadcrumbs()} </div> <script>'use strict'; - AJAX_COMMENT_URL = ${h.js(url('changeset_comment',repo_name=c.repo_name,revision=c.changeset.raw_id))}; - AJAX_COMMENT_DELETE_URL = ${h.js(url('changeset_comment_delete',repo_name=c.repo_name,comment_id='__COMMENT_ID__'))}; + var AJAX_COMMENT_URL = ${h.js(url('changeset_comment',repo_name=c.repo_name,revision=c.changeset.raw_id))}; + var AJAX_COMMENT_DELETE_URL = ${h.js(url('changeset_comment_delete',repo_name=c.repo_name,comment_id='__COMMENT_ID__'))}; </script> <div class="panel-body"> <div class="panel panel-default">
--- a/kallithea/templates/pullrequests/pullrequest_show.html Tue Feb 25 18:03:54 2020 +0100 +++ b/kallithea/templates/pullrequests/pullrequest_show.html Tue Feb 25 18:18:44 2020 +0100 @@ -314,8 +314,8 @@ </div> <script>'use strict'; // TODO: switch this to pyroutes - AJAX_COMMENT_URL = ${h.js(url('pullrequest_comment',repo_name=c.repo_name,pull_request_id=c.pull_request.pull_request_id))}; - AJAX_COMMENT_DELETE_URL = ${h.js(url('pullrequest_comment_delete',repo_name=c.repo_name,comment_id='__COMMENT_ID__'))}; + var AJAX_COMMENT_URL = ${h.js(url('pullrequest_comment',repo_name=c.repo_name,pull_request_id=c.pull_request.pull_request_id))}; + var AJAX_COMMENT_DELETE_URL = ${h.js(url('pullrequest_comment_delete',repo_name=c.repo_name,comment_id='__COMMENT_ID__'))}; pyroutes.register('pullrequest_comment', ${h.js(url('pullrequest_comment',repo_name='%(repo_name)s',pull_request_id='%(pull_request_id)s'))}, ['repo_name', 'pull_request_id']); pyroutes.register('pullrequest_comment_delete', ${h.js(url('pullrequest_comment_delete',repo_name='%(repo_name)s',comment_id='%(comment_id)s'))}, ['repo_name', 'comment_id']);