changeset 2992:3bc8d2e08966 beta

git hook installation should be only executed for git backend
author Marcin Kuzminski <marcin@python-works.com>
date Thu, 08 Nov 2012 14:24:31 +0100
parents 578a152f5ae3
children 716550e1e4fa
files docs/usage/git_support.rst rhodecode/lib/celerylib/tasks.py
diffstat 2 files changed, 6 insertions(+), 7 deletions(-) [+]
line wrap: on
line diff
--- a/docs/usage/git_support.rst	Wed Nov 07 23:36:28 2012 +0100
+++ b/docs/usage/git_support.rst	Thu Nov 08 14:24:31 2012 +0100
@@ -8,16 +8,15 @@
 Git support in RhodeCode 1.3 was enabled by default. You need to have a git
 client installed on the machine to make git fully work.
 
-Although There are some limitations on git usage.
+Although There is one limitation on git usage.
 
-- hooks that are executed on pull/push are not *real* hooks, they are 
-  just emulating the behavior, and are executed **BEFORE** action takes place.
-- large pushes needs http server with chunked encoding support.
+- large pushes requires a http server with chunked encoding support.
  
 if you plan to use git you need to run RhodeCode with some
 http server that supports chunked encoding which git http protocol uses, 
 i recommend using waitress_ or gunicorn_ (linux only) for `paste` wsgi app 
-replacement.
+replacement. Starting from version 1.4 waitress_ is the default wsgi server
+used in RhodeCode.
 
 To use, simply change change the following in the .ini file::
 
--- a/rhodecode/lib/celerylib/tasks.py	Wed Nov 07 23:36:28 2012 +0100
+++ b/rhodecode/lib/celerylib/tasks.py	Thu Nov 08 14:24:31 2012 +0100
@@ -407,6 +407,8 @@
                 src_url=safe_str(source_repo_path),
                 update_after_clone=update_after_clone,
                 bare=True)
+        # add rhodecode hook into this repo
+        ScmModel().install_git_hook(repo=r)
     elif repo_type == 'hg':
         r = backend(safe_str(destination_fork_path), create=True,
                 src_url=safe_str(source_repo_path),
@@ -414,8 +416,6 @@
     else:
         raise Exception('Unknown backend type %s' % repo_type)
 
-    # add rhodecode hook into this repo
-    ScmModel().install_git_hook(repo=r)
     log_create_repository(fork_repo.get_dict(), created_by=cur_user.username)
 
     action_logger(cur_user, 'user_forked_repo:%s' % fork_name,