Mercurial > kallithea

changeset 5359:42c1a1c7ffdd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
comments: cleanup of full_f_path - just put data attribute on div around diff of each file
author Mads Kiilerich <madski@unity3d.com>
date Wed, 05 Aug 2015 12:29:41 +0200
parents 68bdd7646187
children e87baa8f1c5b
files kallithea/public/js/base.js kallithea/templates/changeset/diff_block.html
diffstat 2 files changed, 3 insertions(+), 6 deletions(-) [+]
line wrap: on
line diff
--- a/kallithea/public/js/base.js	Wed Aug 05 12:29:41 2015 +0200
+++ b/kallithea/public/js/base.js	Wed Aug 05 12:29:41 2015 +0200
@@ -654,8 +654,7 @@
         return
     }
     $tr.addClass('form-open hl-comment');
-    var $node = $tr.parent().parent().parent().find('.full_f_path');
-    var f_path = $node.attr('path');
+    var f_path = $tr.parent().closest('.full_f_path').data('f_path');
     var lineno = _getLineNo(tr);
     var $form = _createInlineForm(tr, f_path, lineno, submit_url);
 
--- a/kallithea/templates/changeset/diff_block.html	Wed Aug 05 12:29:41 2015 +0200
+++ b/kallithea/templates/changeset/diff_block.html	Wed Aug 05 12:29:41 2015 +0200
@@ -41,8 +41,7 @@
                 </span>
             </div>
         </div>
-        <div class="code-body">
-            <div class="full_f_path" path="${h.safe_unicode(path)}"></div>
+        <div class="code-body full_f_path" data-f_path="${h.safe_unicode(path)}">
             ${diff|n}
             %if path.rsplit('.')[-1] in ['png', 'gif', 'jpg', 'bmp']:
               <div class="btn btn-image-diff-show">Show images</div>
@@ -104,8 +103,7 @@
               </div>
           </div>
       </div>
-        <div class="code-body">
-            <div class="full_f_path" path="${h.safe_unicode(filenode_path)}"></div>
+        <div class="code-body full_f_path" data-f_path="${h.safe_unicode(filenode_path)}">
             ${diff|n}
             %if filenode_path.rsplit('.')[-1] in ['png', 'gif', 'jpg', 'bmp']:
               <div class="btn btn-image-diff-show">Show images</div>